Commit 1ba87aba authored by Ziye Yang's avatar Ziye Yang Committed by Jim Harris
Browse files

iSCSI: set a connection to EXISTING STATE in condition 



If the connection is already in exiting or exited
status, we should not set it again. And this
could prevent the coredump.

Change-Id: Ia506d13b12c3a6cb5619d65e4b3353b149a85947
Signed-off-by: default avatarZiye Yang <optimistyzy@gmail.com>
Reviewed-on: https://review.gerrithub.io/421668


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent a257328d

lib/iscsi/conn.c

+14 −2
Original line number Diff line number Diff line
@@ -690,8 +690,14 @@ void spdk_shutdown_iscsi_conns(void) 
		if (conn == NULL) {

			continue;

		}



		/* Do not set conn->state if the connection has already started exiting.

		  * This ensures we do not move a connection from EXITED state back to EXITING.

		  */

		if (conn->state < ISCSI_CONN_STATE_EXITING) {

			conn->state = ISCSI_CONN_STATE_EXITING;

		}

	}



	pthread_mutex_unlock(&g_conns_mutex);

	g_shutdown_timer = spdk_poller_register(spdk_iscsi_conn_check_shutdown, NULL,
@@ -749,7 +755,13 @@ spdk_iscsi_drop_conns(struct spdk_iscsi_conn *conn, const char *conn_match, 
			}



			SPDK_DEBUGLOG(SPDK_LOG_ISCSI, "CID=%u\n", xconn->cid);



			/* Do not set xconn->state if the connection has already started exiting.

			  * This ensures we do not move a connection from EXITED state back to EXITING.

			  */

			if (xconn->state < ISCSI_CONN_STATE_EXITING) {

				xconn->state = ISCSI_CONN_STATE_EXITING;

			}

			num++;

		}

	}