Commit 1b0a702c authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

test/unit/blob: remove useless asserts from bs_grow_live_*** unit tests 



There are a couple of asserts that do nothing but make assumptions
that the metadata only consumes one cluster. Remove them since this
assumption will be invalid in upcoming patches which support
larger md page sizes.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I86d0fe487939669d01b604d0155188356a12f794
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25313


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 8fb14726

test/unit/lib/blob/blob.c/blob_ut.c

+0 −4
Original line number Diff line number Diff line
@@ -3049,7 +3049,6 @@ bs_grow_live_size(uint64_t new_blockcnt) 
	CU_ASSERT(g_bserrno == 0);

	SPDK_CU_ASSERT_FATAL(g_bs != NULL);

	bs = g_bs;

	CU_ASSERT(spdk_bs_total_data_cluster_count(bs) == 63);



	/*

	 * Set the dev size according to the new_blockcnt,
@@ -3061,8 +3060,6 @@ bs_grow_live_size(uint64_t new_blockcnt) 
	poll_threads();

	CU_ASSERT(g_bserrno == 0);

	total_data_clusters = spdk_bs_total_data_cluster_count(bs);

	/* One cluster of 1MiB size is used for metadata */

	CU_ASSERT(total_data_clusters == (bdev_size / (1 * 1024 * 1024)) - 1);



	/* Make sure the super block is updated. */

	memcpy(&super_block, g_dev_buffer, sizeof(struct spdk_bs_super_block));
@@ -3153,7 +3150,6 @@ bs_grow_live_no_space(void) 
	SPDK_CU_ASSERT_FATAL(g_bs != NULL);

	bs = g_bs;

	total_data_clusters = spdk_bs_total_data_cluster_count(bs);

	CU_ASSERT(total_data_clusters == 63);



	/*

	 * The default dev size is 64M, here we set the dev size to 32M,