Commit 1a9a4f51 authored by zhenwei pi's avatar zhenwei pi Committed by Tomasz Zawadzki
Browse files

scsi: Add helper function spdk_scsi_sbc_opcode_string 



Translate SCSI operation code and service action into string, human
readable string is helpful for debug. Exporting this function as
public, it's possible to be used outside(ex, virtio scsi).

Change-Id: I74231c63bc73fcd6acfee385021e0bcc460cbf7f
Suggested-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Signed-off-by: default avatarzhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20464


Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent ea97fbd2

include/spdk/scsi.h

+11 −0
Original line number Diff line number Diff line
@@ -597,6 +597,17 @@ uint64_t spdk_scsi_lun_id_int_to_fmt(int lun_id); 
 * \return integer LUN ID

 */

int spdk_scsi_lun_id_fmt_to_int(uint64_t fmt_lun);



/**

 * Translate SCSI operation code and service action into string

 *

 * \param opcode SCSI operation code

 *

 * \param sa SCSI service action code

 *

 * \return SCSI operation string

 */

const char *spdk_scsi_sbc_opcode_string(uint8_t opcode, uint16_t sa);

#ifdef __cplusplus

}

#endif

lib/scsi/scsi.c

+63 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
 */



#include "scsi_internal.h"

#include "spdk/util.h"



int

spdk_scsi_init(void)
@@ -70,4 +71,66 @@ spdk_scsi_lun_id_fmt_to_int(uint64_t fmt_lun) 
	return lun_i;

}



struct scsi_sbc_opcode_string {

	enum spdk_sbc_opcode opc;

	const char *str;

};



static const struct scsi_sbc_opcode_string scsi_sbc_opcode_strings[] = {

	{ SPDK_SBC_COMPARE_AND_WRITE, "COMPARE AND WRITE" },

	{ SPDK_SBC_FORMAT_UNIT, "FORMAT UNIT" },

	{ SPDK_SBC_GET_LBA_STATUS, "GET LBA STATUS" },

	{ SPDK_SBC_ORWRITE_16, "ORWRITE 16" },

	{ SPDK_SBC_PRE_FETCH_10, "PRE FETCH 10" },

	{ SPDK_SBC_PRE_FETCH_16, "PRE FETCH 16" },

	{ SPDK_SBC_READ_6, "READ 6" },

	{ SPDK_SBC_READ_10, "READ 10" },

	{ SPDK_SBC_READ_12, "READ 12" },

	{ SPDK_SBC_READ_16, "READ 16" },

	{ SPDK_SBC_READ_ATTRIBUTE, "READ ATTRIBUTE" },

	{ SPDK_SBC_READ_BUFFER, "READ BUFFER" },

	{ SPDK_SBC_READ_CAPACITY_10, "READ CAPACITY 10" },

	{ SPDK_SBC_READ_DEFECT_DATA_10, "READ DEFECT DATA 10" },

	{ SPDK_SBC_READ_DEFECT_DATA_12, "READ DEFECT DATA 12" },

	{ SPDK_SBC_READ_LONG_10, "READ LONG 10" },

	{ SPDK_SBC_REASSIGN_BLOCKS, "REASSIGN BLOCKS" },

	{ SPDK_SBC_SANITIZE, "SANITIZE" },

	{ SPDK_SBC_START_STOP_UNIT, "START STOP UNIT" },

	{ SPDK_SBC_SYNCHRONIZE_CACHE_10, "SYNCHRONIZE CACHE 10" },

	{ SPDK_SBC_SYNCHRONIZE_CACHE_16, "SYNCHRONIZE CACHE 16" },

	{ SPDK_SBC_UNMAP, "UNMAP" },

	{ SPDK_SBC_VERIFY_10, "VERIFY 10" },

	{ SPDK_SBC_VERIFY_12, "VERIFY 12" },

	{ SPDK_SBC_VERIFY_16, "VERIFY 16" },

	{ SPDK_SBC_WRITE_6, "WRITE 6" },

	{ SPDK_SBC_WRITE_10, "WRITE 10" },

	{ SPDK_SBC_WRITE_12, "WRITE 12" },

	{ SPDK_SBC_WRITE_16, "WRITE 16" },

	{ SPDK_SBC_WRITE_AND_VERIFY_10, "WRITE AND VERIFY 10" },

	{ SPDK_SBC_WRITE_AND_VERIFY_12, "WRITE AND VERIFY 12" },

	{ SPDK_SBC_WRITE_AND_VERIFY_16, "WRITE AND VERIFY 16" },

	{ SPDK_SBC_WRITE_LONG_10, "WRITE LONG 10" },

	{ SPDK_SBC_WRITE_SAME_10, "WRITE SAME 10" },

	{ SPDK_SBC_WRITE_SAME_16, "WRITE SAME 16" },

	{ SPDK_SBC_XDREAD_10, "XDREAD 10" },

	{ SPDK_SBC_XDWRITE_10, "XDWRITE 10" },

	{ SPDK_SBC_XDWRITEREAD_10, "XDWRITEREAD 10" },

	{ SPDK_SBC_XPWRITE_10, "XPWRITE 10" }

};



const char *

spdk_scsi_sbc_opcode_string(uint8_t opcode, uint16_t sa)

{

	uint8_t i;



	/* FIXME: sa is unsupported currently, support variable length CDBs if necessary */

	for (i = 0; i < SPDK_COUNTOF(scsi_sbc_opcode_strings); i++) {

		if (scsi_sbc_opcode_strings[i].opc == opcode) {

			return scsi_sbc_opcode_strings[i].str;

		}

	}



	return "UNKNOWN";

}



SPDK_LOG_REGISTER_COMPONENT(scsi)

lib/scsi/spdk_scsi.map

+1 −0
Original line number Diff line number Diff line
@@ -48,6 +48,7 @@ 
	spdk_scsi_lun_id_fmt_to_int;

	spdk_scsi_dev_construct_ext;

	spdk_scsi_dev_add_lun_ext;

	spdk_scsi_sbc_opcode_string;



	local: *;

};