Commit 198fd2ce authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

lib/nvmf: remove spdk prefix from static functions in ctrlr.c 



Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: Ibb72c2fb687506831988b09fddad4fc3dae0e4ad
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2282


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent ce42d9d1

lib/nvmf/ctrlr.c

+132 −132

File changed.

Preview size limit exceeded, changes collapsed.

test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c

+39 −39
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ test_get_log_page(void) 
	cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;

	cmd.nvme_cmd.cdw10_bits.get_log_page.lid = SPDK_NVME_LOG_ERROR;

	cmd.nvme_cmd.cdw10_bits.get_log_page.numdl = (req.length / 4 - 1);

	CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
@@ -239,7 +239,7 @@ test_get_log_page(void) 
	memset(&rsp, 0, sizeof(rsp));

	cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;

	cmd.nvme_cmd.cdw10 = 0;

	CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -250,7 +250,7 @@ test_get_log_page(void) 
	cmd.nvme_cmd.cdw10_bits.get_log_page.lid = SPDK_NVME_LOG_ERROR;

	cmd.nvme_cmd.cdw10_bits.get_log_page.numdl = (req.length / 4 - 1);

	cmd.nvme_cmd.cdw12 = 2;

	CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -261,7 +261,7 @@ test_get_log_page(void) 
	cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;

	cmd.nvme_cmd.cdw10_bits.get_log_page.lid = SPDK_NVME_LOG_ERROR;

	cmd.nvme_cmd.cdw10_bits.get_log_page.numdl = (req.length / 4 - 1);

	CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);

	req.data = data;
@@ -388,13 +388,13 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));

	CU_ASSERT(qpair.ctrlr != NULL);

	CU_ASSERT(sgroups[subsystem.id].io_outstanding == 0);

	spdk_nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	spdk_bit_array_free(&qpair.ctrlr->qpair_mask);

	free(qpair.ctrlr);

	qpair.ctrlr = NULL;
@@ -404,7 +404,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
@@ -419,7 +419,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	req.length = sizeof(connect_data) - 1;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
@@ -431,7 +431,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	cmd.connect_cmd.recfmt = 1234;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -443,7 +443,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	MOCK_SET(spdk_nvmf_tgt_find_subsystem, NULL);

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -457,7 +457,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	memset(connect_data.hostnqn, 'b', sizeof(connect_data.hostnqn));

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -471,7 +471,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	MOCK_SET(spdk_nvmf_subsystem_host_allowed, false);

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -483,7 +483,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	cmd.connect_cmd.sqsize = 0;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -497,7 +497,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	cmd.connect_cmd.sqsize = 32;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -512,7 +512,7 @@ test_connect(void) 
	cmd.connect_cmd.qid = 1;

	cmd.connect_cmd.sqsize = 64;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -527,7 +527,7 @@ test_connect(void) 
	memset(&rsp, 0, sizeof(rsp));

	connect_data.cntlid = 0x1234;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -547,7 +547,7 @@ test_connect(void) 
	cmd.connect_cmd.sqsize = 63;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
@@ -561,7 +561,7 @@ test_connect(void) 
	MOCK_SET(nvmf_subsystem_get_ctrlr, NULL);

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -578,7 +578,7 @@ test_connect(void) 
	subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -596,14 +596,14 @@ test_connect(void) 
	subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));

	CU_ASSERT(qpair.ctrlr != NULL);

	CU_ASSERT(qpair.ctrlr->keep_alive_poller != NULL);

	CU_ASSERT(sgroups[subsystem.id].io_outstanding == 0);

	spdk_nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	spdk_bit_array_free(&qpair.ctrlr->qpair_mask);

	free(qpair.ctrlr);

	qpair.ctrlr = NULL;
@@ -617,14 +617,14 @@ test_connect(void) 
	subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));

	CU_ASSERT(qpair.ctrlr != NULL);

	CU_ASSERT(qpair.ctrlr->keep_alive_poller != NULL);

	CU_ASSERT(sgroups[subsystem.id].io_outstanding == 0);

	spdk_nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);

	spdk_bit_array_free(&qpair.ctrlr->qpair_mask);

	free(qpair.ctrlr);

	qpair.ctrlr = NULL;
@@ -637,7 +637,7 @@ test_connect(void) 
	ctrlr.vcprop.cc.bits.en = 0;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -653,7 +653,7 @@ test_connect(void) 
	ctrlr.vcprop.cc.bits.iosqes = 3;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -669,7 +669,7 @@ test_connect(void) 
	ctrlr.vcprop.cc.bits.iocqes = 3;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -687,7 +687,7 @@ test_connect(void) 
	spdk_bit_array_set(ctrlr.qpair_mask, 2);

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -707,7 +707,7 @@ test_connect(void) 
	cmd.connect_cmd.qid = 1;

	sgroups[subsystem.id].io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = spdk_nvmf_ctrlr_cmd_connect(&req);

	rc = nvmf_ctrlr_cmd_connect(&req);

	poll_threads();

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
@@ -956,7 +956,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.opc = SPDK_NVME_OPC_SET_FEATURES;

	cmd.nvme_cmd.cdw11_bits.feat_rsv_persistence.bits.ptpl = 1;

	ns[0].ptpl_file = "testcfg";

	rc = spdk_nvmf_ctrlr_set_features_reservation_persistence(&req);

	rc = nvmf_ctrlr_set_features_reservation_persistence(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_FEATURE_ID_NOT_SAVEABLE);
@@ -965,7 +965,7 @@ test_set_get_features(void) 
	/* Get SPDK_NVME_FEAT_HOST_RESERVE_PERSIST feature */

	cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_FEATURES;

	cmd.nvme_cmd.cdw10_bits.get_features.fid = SPDK_NVME_FEAT_HOST_RESERVE_PERSIST;

	rc = spdk_nvmf_ctrlr_get_features_reservation_persistence(&req);

	rc = nvmf_ctrlr_get_features_reservation_persistence(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
@@ -977,7 +977,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11 = 0x42;

	cmd.nvme_cmd.cdw10_bits.get_features.fid = SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD;



	rc = spdk_nvmf_ctrlr_get_features(&req);

	rc = nvmf_ctrlr_get_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);



	/* Get SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD - invalid TMPSEL */
@@ -985,7 +985,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11 = 0x42 | 1 << 16 | 1 << 19; /* Set reserved value */

	cmd.nvme_cmd.cdw10_bits.get_features.fid = SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD;



	rc = spdk_nvmf_ctrlr_get_features(&req);

	rc = nvmf_ctrlr_get_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -995,7 +995,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11 = 0x42;

	cmd.nvme_cmd.cdw10_bits.set_features.fid = SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD;



	rc = spdk_nvmf_ctrlr_set_features(&req);

	rc = nvmf_ctrlr_set_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);



	/* Set SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD - invalid TMPSEL */
@@ -1003,7 +1003,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11 = 0x42 | 1 << 16 | 1 << 19; /* Set reserved value */

	cmd.nvme_cmd.cdw10_bits.set_features.fid = SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD;



	rc = spdk_nvmf_ctrlr_set_features(&req);

	rc = nvmf_ctrlr_set_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -1014,7 +1014,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11_bits.feat_temp_threshold.bits.thsel = 0x3; /* Set reserved value */

	cmd.nvme_cmd.cdw10_bits.set_features.fid = SPDK_NVME_FEAT_TEMPERATURE_THRESHOLD;



	rc = spdk_nvmf_ctrlr_set_features(&req);

	rc = nvmf_ctrlr_set_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -1024,7 +1024,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.opc = SPDK_NVME_OPC_SET_FEATURES;

	cmd.nvme_cmd.cdw10_bits.get_features.fid = SPDK_NVME_FEAT_ERROR_RECOVERY;



	rc = spdk_nvmf_ctrlr_get_features(&req);

	rc = nvmf_ctrlr_get_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);



	/* Set SPDK_NVME_FEAT_ERROR_RECOVERY - DULBE set */
@@ -1033,7 +1033,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11_bits.feat_error_recovery.bits.dulbe = 0x1;

	cmd.nvme_cmd.cdw10_bits.set_features.fid = SPDK_NVME_FEAT_ERROR_RECOVERY;



	rc = spdk_nvmf_ctrlr_set_features(&req);

	rc = nvmf_ctrlr_set_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

	CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);

	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
@@ -1044,7 +1044,7 @@ test_set_get_features(void) 
	cmd.nvme_cmd.cdw11_bits.feat_error_recovery.bits.dulbe = 0x0;

	cmd.nvme_cmd.cdw10_bits.set_features.fid = SPDK_NVME_FEAT_ERROR_RECOVERY;



	rc = spdk_nvmf_ctrlr_set_features(&req);

	rc = nvmf_ctrlr_set_features(&req);

	CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);

}
@@ -1321,7 +1321,7 @@ test_reservation_notification_log_page(void) 
	SPDK_CU_ASSERT_FATAL(ctrlr.num_avail_log_pages == 3);



	/* Test Case: Get Log Page to clear the log pages */

	spdk_nvmf_get_reservation_notification_log_page(&ctrlr, (void *)logs, 0, sizeof(logs));

	nvmf_get_reservation_notification_log_page(&ctrlr, (void *)logs, 0, sizeof(logs));

	SPDK_CU_ASSERT_FATAL(ctrlr.num_avail_log_pages == 0);

}