Commit 18dc53c5 authored Oct 01, 2019 by Seth Howell Committed by Jim Harris Oct 07, 2019

nvme: move submit_request impl to a private function



This patch series is aimed at preserving the order of qpair entries
when resubmitting queued requests. The hope is that we will make the API
fool proof and future proof against ever reordering any queued requests.

Change-Id: Ib20d61d3abaed637c9c305b75081947630190fd4
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470062


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com>

parent 2fec3037

lib/nvme/nvme_qpair.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -537,8 +537,8 @@ nvme_qpair_deinit(struct spdk_nvme_qpair *qpair)
		spdk_free(qpair->req_buf);
		}

		int
		nvme_qpair_submit_request(struct spdk_nvme_qpair qpair, struct nvme_request req)
		static inline int
		_nvme_qpair_submit_request(struct spdk_nvme_qpair qpair, struct nvme_request req)
		{
		int rc = 0;
		struct nvme_request child_req, tmp;
		@@ -647,6 +647,12 @@ error:
		return rc;
		}

		int
		nvme_qpair_submit_request(struct spdk_nvme_qpair qpair, struct nvme_request req)
		{
		return _nvme_qpair_submit_request(qpair, req);
		}

		void
		nvme_qpair_enable(struct spdk_nvme_qpair *qpair)
		{