Commit 18506bf1 authored by Michal Berger's avatar Michal Berger Committed by Tomasz Zawadzki
Browse files

scripts/pkgdep: Make sure supported version of golangci-lint is installed 



golangci-lint's install.sh always attempts to install latest release
unless explicitly told which TAG to use. Having that in mind, pass
our $lintversion on its cmdline.

Best way to avoid similar mishaps is to avoid using interim scripts
like that and fetch needed pieces directly.

Change-Id: Id4060bf324cef0a164c70fe3f1690d5ec8da74a6
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23290


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarPawel Piatek <pawelx.piatek@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarMarek Chomnicki <marek.chomnicki@intel.com>
parent e71c185e

scripts/pkgdep/common.sh

+1 −1
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ install_golangci_lint() { 
	golangcidir=/opt/golangci/$lintversion/bin

	export PATH=${golangcidir}:$PATH

	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v${lintversion}/install.sh \

		| sh -s -- -b "${golangcidir}" || {

		| sh -s -- -b "${golangcidir}" "v$lintversion" || {

		echo "installing golangci-lint failed"

		return 1

	}