Commit 1826c4dc authored by Sebastian Brzezinka's avatar Sebastian Brzezinka Committed by Jim Harris
Browse files

autotest: Run `sw_hotplug` test with ASan enabled 

Orginal comment that prevent `sw_hotplug` execution with ASan clamis
that "... it catches SEGV earlier than our handler which breaks the
hotplug logic"

But when running ASan on all jobs
(https://review.spdk.io/gerrit/c/spdk/spdk/+/20722

), the
above-mentioned problem did not appear. Even when ASan was enabled,
and the SPDK_RUN_ASAN flag was not set.

Therefore, it seems that ASan does not exclude the possibility of
running `sw_hotplug' anymore.

Change-Id: I3e371cf69d680fd9362c48d179f164f936102ea9
Signed-off-by: default avatarSebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23033


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent b084cba0

autotest.sh

+2 −4
Original line number Diff line number Diff line
@@ -235,10 +235,8 @@ if [ $SPDK_RUN_FUNCTIONAL_TEST -eq 1 ]; then 


		run_test "nvme_rpc" $rootdir/test/nvme/nvme_rpc.sh

		run_test "nvme_rpc_timeouts" $rootdir/test/nvme/nvme_rpc_timeouts.sh

		# Only test hotplug without ASAN enabled. Since if it is

		# enabled, it catches SEGV earlier than our handler which

		# breaks the hotplug logic.

		if [ $SPDK_RUN_ASAN -eq 0 ] && [ $(uname -s) = Linux ]; then



		if [ $(uname -s) = Linux ]; then

			run_test "sw_hotplug" $rootdir/test/nvme/sw_hotplug.sh

		fi