Commit 17e9d38c authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

test/unit: Fix Scan-build errors in scsi tests 



I had to make small modifications to one test in the dev_ut.c file to
prevent a memory leak error. However, changing the index in this test
from -1 to 0 has no effect on the coverage.

Change-Id: Ia8a475aaa41118f072a5d9006bab9d9c84b4a10a
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/424126


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent c0297f9c

test/unit/lib/scsi/dev.c/dev_ut.c

+2 −1
Original line number Diff line number Diff line
@@ -555,8 +555,9 @@ dev_add_lun_bdev_not_found(void) 
	int rc;

	struct spdk_scsi_dev dev = {0};



	rc = spdk_scsi_dev_add_lun(&dev, "malloc2", -1, NULL, NULL);

	rc = spdk_scsi_dev_add_lun(&dev, "malloc2", 0, NULL, NULL);



	SPDK_CU_ASSERT_FATAL(dev.lun[0] == NULL);

	CU_ASSERT_NOT_EQUAL(rc, 0);

}

test/unit/lib/scsi/scsi_bdev.c/scsi_bdev_ut.c

+6 −0
Original line number Diff line number Diff line
@@ -689,6 +689,8 @@ lba_range_test(void) 


	ut_init_task(&task);

	task.lun = &lun;

	task.lun->bdev_desc = NULL;

	task.lun->io_channel = NULL;

	task.cdb = cdb;



	memset(cdb, 0, sizeof(cdb));
@@ -760,6 +762,8 @@ xfer_len_test(void) 


	ut_init_task(&task);

	task.lun = &lun;

	task.lun->bdev_desc = NULL;

	task.lun->io_channel = NULL;

	task.cdb = cdb;



	memset(cdb, 0, sizeof(cdb));
@@ -847,6 +851,8 @@ _xfer_test(bool bdev_io_pool_full) 
	/* Read 1 block */

	ut_init_task(&task);

	task.lun = &lun;

	task.lun->bdev_desc = NULL;

	task.lun->io_channel = NULL;

	task.cdb = cdb;

	memset(cdb, 0, sizeof(cdb));

	cdb[0] = 0x88; /* READ (16) */