Commit 154323ab authored by Dariusz Stojaczyk's avatar Dariusz Stojaczyk Committed by Jim Harris
Browse files

scsi: Include null terminator in Unit Serial Number VPD Page 



According to the scsi standard, all ASCII data fields "may be
terminated with one or more ASCII null (00h) characters"
[7.6.10, 4.4.1]. Windows SCSI Compliance tests expect a null terminator
there, so let's include it.

Change-Id: I18fa35295233a163cea711a5c4ff8e3d3e80c4f1
Signed-off-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
parent c2c995c5

lib/scsi/scsi_bdev.c

+3 −2
Original line number Diff line number Diff line
@@ -222,12 +222,13 @@ spdk_bdev_scsi_inquiry(struct spdk_bdev *bdev, struct spdk_scsi_task *task, 
			hlen = 4;



			/* PRODUCT SERIAL NUMBER */

			len = strlen(bdev->name);

			len = strlen(bdev->name) + 1;

			if (len > MAX_SERIAL_STRING) {

				len = MAX_SERIAL_STRING;

			}



			spdk_strcpy_pad(vpage->params, bdev->name, len, ' ');

			memcpy(vpage->params, bdev->name, len - 1);

			vpage->params[len - 1] = 0;



			/* PAGE LENGTH */

			to_be16(vpage->alloc_len, len);