Commit 14034200 authored Jul 09, 2019 by Tomasz Zawadzki Committed by Ben Walker Jul 12, 2019

test/bdevio: present info when RPC lib is missing from PYTHONPATH



The test.py script relies upon importing SPDK Python RPC libs.
This requires user to add ./spdk/scripts/ to PYTHONPATH.

Unfortunately --help could not be reached when the import failed,
to user executing the script directly wouldn't know that.

This patch adds instructions for user when importing
RPC lib fails.

Change-Id: Icb87fbc5ae9d1c5b71699827d6ea0cd922d38627
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/460908


Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent feff62c7

test/bdev/bdevio/tests.py

+8 −4

Original line number	Diff line number	Diff line
		#!/usr/bin/env python3

		from rpc.client import print_dict, JSONRPCException

		import logging
		import argparse
		import rpc
		import sys
		import shlex

		try:
		from rpc.client import print_dict, JSONRPCException
		import rpc
		except ImportError:
		print("SPDK RPC library missing. Please add spdk/scripts/ directory to PYTHONPATH:")
		print("'export PYTHONPATH=$PYTHONPATH:./spdk/scripts/'")
		exit(1)

		try:
		from shlex import quote
		except ImportError: