Commit 11ccf3be authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

test/unit: Fix scan-build errors in bdev unittests 



Fixes a use after free error in bdev/bdev_ut
Fixes an uninitialized argument value error in mt/bdev/bdev_ut
Adds extra checks in the spdk_bdev_part_construct code
Fixes a dereference of null pointer error in bdev/vbdev_lvol_ut
Change-Id: I1eaa6ebfec0a36a0d910504c70b16ccc651de22a
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/423923


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent c8341f12

test/unit/lib/bdev/bdev.c/bdev_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -604,7 +604,7 @@ alias_add_del_test(void) 


	/* Trying to del all alias from empty alias list */

	spdk_bdev_alias_del_all(bdev[2]);

	CU_ASSERT(TAILQ_EMPTY(&bdev[2]->aliases));

	SPDK_CU_ASSERT_FATAL(TAILQ_EMPTY(&bdev[2]->aliases));



	/* Trying to del all alias from non-empty alias list */

	rc = spdk_bdev_alias_add(bdev[2], "alias0");

test/unit/lib/bdev/mt/bdev.c/bdev_ut.c

+2 −1
Original line number Diff line number Diff line
@@ -990,7 +990,7 @@ enomem_multi_io_target(void) 
	uint32_t i;

	int new_io_device;

	struct ut_bdev *second_bdev;

	struct spdk_bdev_desc *second_desc;

	struct spdk_bdev_desc *second_desc = NULL;

	struct spdk_bdev_channel *second_bdev_ch;

	struct spdk_io_channel *second_ch;

	int rc;
@@ -1004,6 +1004,7 @@ enomem_multi_io_target(void) 
	SPDK_CU_ASSERT_FATAL(second_bdev != NULL);

	register_bdev(second_bdev, "ut_bdev2", &new_io_device);

	spdk_bdev_open(&second_bdev->bdev, true, NULL, NULL, &second_desc);

	SPDK_CU_ASSERT_FATAL(second_desc != NULL);



	set_thread(0);

	io_ch = spdk_bdev_get_io_channel(g_desc);

test/unit/lib/bdev/part.c/part_ut.c

+4 −2
Original line number Diff line number Diff line
@@ -121,8 +121,10 @@ part_test(void) 


	SPDK_CU_ASSERT_FATAL(base != NULL);



	spdk_bdev_part_construct(&part1, base, "test1", 0, 100, "test");

	spdk_bdev_part_construct(&part2, base, "test2", 100, 100, "test");

	rc = spdk_bdev_part_construct(&part1, base, "test1", 0, 100, "test");

	SPDK_CU_ASSERT_FATAL(rc == 0);

	rc = spdk_bdev_part_construct(&part2, base, "test2", 100, 100, "test");

	SPDK_CU_ASSERT_FATAL(rc == 0);



	spdk_bdev_part_base_hotremove(&bdev_base, &tailq);

test/unit/lib/bdev/vbdev_lvol.c/vbdev_lvol_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -766,7 +766,7 @@ ut_lvol_snapshot(void) 
	g_lvolerrno = -1;

	rc = vbdev_lvol_create(lvs, "lvol", sz, false, vbdev_lvol_create_complete, NULL);

	SPDK_CU_ASSERT_FATAL(rc == 0);

	CU_ASSERT(g_lvol != NULL);

	SPDK_CU_ASSERT_FATAL(g_lvol != NULL);

	CU_ASSERT(g_lvolerrno == 0);



	lvol = g_lvol;