Commit 11c8fbcf authored by Wojciech Malikowski's avatar Wojciech Malikowski Committed by Jim Harris
Browse files

lib/ftl: Fix memory leak in restore module 



Change-Id: I39c89ef935eeac56fd860b11e1fafd5047072f7e
Signed-off-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448023


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent d058328e

lib/ftl/ftl_restore.c

+6 −1
Original line number Diff line number Diff line
@@ -62,6 +62,8 @@ struct ftl_restore { 
	void				*md_buf;



	void				*lba_map;



	bool				l2p_phase;

};



static int
@@ -94,6 +96,7 @@ ftl_restore_init(struct spdk_ftl_dev *dev, ftl_restore_fn cb) 


	restore->dev = dev;

	restore->cb = cb;

	restore->l2p_phase = false;



	restore->bands = calloc(ftl_dev_num_bands(dev), sizeof(*restore->bands));

	if (!restore->bands) {
@@ -131,9 +134,10 @@ static void 
ftl_restore_complete(struct ftl_restore *restore, int status)

{

	struct ftl_restore *ctx = status ? NULL : restore;

	bool l2p_phase = restore->l2p_phase;



	restore->cb(restore->dev, ctx, status);

	if (status) {

	if (status || l2p_phase) {

		ftl_restore_free(restore);

	}

}
@@ -409,6 +413,7 @@ ftl_restore_device(struct ftl_restore *restore, ftl_restore_fn cb) 
{

	struct ftl_restore_band *rband;



	restore->l2p_phase = true;

	restore->current = 0;

	restore->cb = cb;