Commit 11b38a58 authored by Jim Harris's avatar Jim Harris Committed by Changpeng Liu
Browse files

app, log: clarify how to enable log flags 



Let's point users to use --enable-debug now instead of
CONFIG_DEBUG=y.  Also to be completely pedantic, use
"configure" instead of "build" to make it more clear
this flag needs to be passed to the configure script,
not make.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I4a6f6313a4f8e87cbb1d79cb68645305abb0e106

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449339


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent a0070df9

lib/event/app.c

+1 −1
Original line number Diff line number Diff line
@@ -934,7 +934,7 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts, 
			break;

		case LOGFLAG_OPT_IDX:

#ifndef DEBUG

			fprintf(stderr, "%s must be built with CONFIG_DEBUG=y for -L flag\n",

			fprintf(stderr, "%s must be configured with --enable-debug for -L flag\n",

				argv[0]);

			usage(app_usage);

			goto out;

lib/log/log_flags.c

+1 −1
Original line number Diff line number Diff line
@@ -197,6 +197,6 @@ spdk_log_usage(FILE *f, const char *log_arg) 
	fprintf(f, ")\n");

#else

	fprintf(f, " %s, --logflag <flag>    enable debug log flag (not supported"

		" - must rebuild with --enable-debug)\n", log_arg);

		" - must reconfigure with --enable-debug)\n", log_arg);

#endif

}