Commit 1136107e authored by Changpeng Liu's avatar Changpeng Liu Committed by Ben Walker
Browse files

nvme: optimize the error log when OPAL isn't supported 



We will print a notice log if the drive can support SECURITY
SEND/RECEIVE commands but not OPAL, so remove the error logs.

Change-Id: Ib26aa727ad1e703d53c387af8507b920606ea9c6
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8055


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 475fadf3

module/bdev/nvme/bdev_nvme.c

+0 −3
Original line number Diff line number Diff line
@@ -1854,9 +1854,6 @@ _nvme_bdev_ctrlr_create(struct spdk_nvme_ctrlr *ctrlr, 
	if (spdk_nvme_ctrlr_get_flags(nvme_bdev_ctrlr->ctrlr) &

	    SPDK_NVME_CTRLR_SECURITY_SEND_RECV_SUPPORTED) {

		nvme_bdev_ctrlr->opal_dev = spdk_opal_dev_construct(nvme_bdev_ctrlr->ctrlr);

		if (nvme_bdev_ctrlr->opal_dev == NULL) {

			SPDK_ERRLOG("Failed to initialize Opal\n");

		}

	}



	TAILQ_INSERT_HEAD(&nvme_bdev_ctrlr->trids, trid_entry, link);