Commit 0f7bdc52 authored by Michal Berger's avatar Michal Berger Committed by Tomasz Zawadzki
Browse files

test/nvme: Set SEL only when the field is supported 



Some nvmes don't support it, hence it should be set conditionally.

Change-Id: I39bd1940b0fd00d18e3566beca5449bf49cd245d
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21645


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent e229a40f

test/nvme/cuse/spdk_nvme_cli_cuse.sh

+8 −2
Original line number Diff line number Diff line
@@ -24,6 +24,12 @@ if ! nvme_name=$(get_nvme_with_ns_management); then 
	exit 1

fi



sel_cmd=()

# sel depends on ONCS.4 so make sure it's set

if (($(get_oncs "$nvme_name") & 1 << 4)); then

	sel_cmd=(-s 1) # return default attribute value

fi



ctrlr="/dev/${nvme_name}"

ns="/dev/${nvme_name}n1"

bdf=${bdfs["$nvme_name"]}
@@ -44,7 +50,7 @@ if [ "$oacs_firmware" -ne "0" ]; then 
fi

${NVME_CMD} smart-log $ctrlr

${NVME_CMD} error-log $ctrlr > ${KERNEL_OUT}.7

${NVME_CMD} get-feature $ctrlr -f 1 -s 1 -l 100 > ${KERNEL_OUT}.8

${NVME_CMD} get-feature $ctrlr -f 1 "${sel_cmd[@]}" -l 100 > ${KERNEL_OUT}.8

${NVME_CMD} get-log $ctrlr -i 1 -l 100 > ${KERNEL_OUT}.9

${NVME_CMD} reset $ctrlr > ${KERNEL_OUT}.10

# Negative test to make sure status message is the same on failures
@@ -81,7 +87,7 @@ if [ "$oacs_firmware" -ne "0" ]; then 
fi

${NVME_CMD} smart-log $ctrlr

${NVME_CMD} error-log $ctrlr > ${CUSE_OUT}.7

${NVME_CMD} get-feature $ctrlr -f 1 -s 1 -l 100 > ${CUSE_OUT}.8

${NVME_CMD} get-feature $ctrlr -f 1 "${set_cmd[@]}" -l 100 > ${CUSE_OUT}.8

${NVME_CMD} get-log $ctrlr -i 1 -l 100 > ${CUSE_OUT}.9

${NVME_CMD} reset $ctrlr > ${CUSE_OUT}.10

${NVME_CMD} set-feature $ctrlr -n 1 -f 2 -v 0 2> ${CUSE_OUT}.11 || true