Commit 0ed9c53f authored by Krzysztof Sprzaczkowski's avatar Krzysztof Sprzaczkowski Committed by Tomasz Zawadzki
Browse files

test/unit: DIF insert DSA unit tests 



Extend the test module with DIF Insert operation unit tests.

Change-Id: Ied46a90903f047f323b3e269e59a46ac4a8a6e21
Signed-off-by: default avatarKrzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Signed-off-by: default avatarSlawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20279


Reviewed-by: default avatarSebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent da954d0a

test/unit/lib/idxd/idxd.c/idxd_ut.c

+105 −0
Original line number Diff line number Diff line
@@ -223,6 +223,71 @@ test_idxd_validate_dif_check_params(void) 
	CU_ASSERT(rc == 0);

}



static void

test_idxd_validate_dif_insert_params(void)

{

	struct spdk_dif_ctx dif_ctx;

	struct spdk_dif_ctx_init_ext_opts dif_opts;

	int rc;



	dif_opts.size = SPDK_SIZEOF(&dif_opts, dif_pi_format);

	dif_opts.dif_pi_format = SPDK_DIF_PI_FORMAT_16;



	/* Check for required DIF flags */

	/* ## supported: Guard, ApplicationTag, ReferenceTag check flags set */

	rc = spdk_dif_ctx_init(&dif_ctx,

			       512 + 8,

			       8,

			       true,

			       false,

			       SPDK_DIF_TYPE1,

			       SPDK_DIF_FLAGS_GUARD_CHECK | SPDK_DIF_FLAGS_APPTAG_CHECK |

			       SPDK_DIF_FLAGS_REFTAG_CHECK,

			       0, 0, 0, 0, 0, &dif_opts);

	CU_ASSERT(rc == 0);

	rc = idxd_validate_dif_insert_params(&dif_ctx);

	CU_ASSERT(rc == 0);



	/* ## not-supported: Guard check flag not set */

	rc = spdk_dif_ctx_init(&dif_ctx,

			       512 + 8,

			       8,

			       true,

			       false,

			       SPDK_DIF_TYPE1,

			       SPDK_DIF_FLAGS_APPTAG_CHECK | SPDK_DIF_FLAGS_REFTAG_CHECK,

			       0, 0, 0, 0, 0, &dif_opts);

	CU_ASSERT(rc == 0);

	rc = idxd_validate_dif_insert_params(&dif_ctx);

	CU_ASSERT(rc == -EINVAL);



	/* ## not-supported: Application Tag check flag not set */

	rc = spdk_dif_ctx_init(&dif_ctx,

			       512 + 8,

			       8,

			       true,

			       false,

			       SPDK_DIF_TYPE1,

			       SPDK_DIF_FLAGS_GUARD_CHECK | SPDK_DIF_FLAGS_REFTAG_CHECK,

			       0, 0, 0, 0, 0, &dif_opts);

	CU_ASSERT(rc == 0);

	rc = idxd_validate_dif_insert_params(&dif_ctx);

	CU_ASSERT(rc == -EINVAL);



	/* ## not-supported: Reference Tag check flag not set */

	rc = spdk_dif_ctx_init(&dif_ctx,

			       512 + 8,

			       8,

			       true,

			       false,

			       SPDK_DIF_TYPE1,

			       SPDK_DIF_FLAGS_GUARD_CHECK | SPDK_DIF_FLAGS_APPTAG_CHECK,

			       0, 0, 0, 0, 0, &dif_opts);

	CU_ASSERT(rc == 0);

	rc = idxd_validate_dif_insert_params(&dif_ctx);

	CU_ASSERT(rc == -EINVAL);

}



static void

test_idxd_validate_dif_check_buf_align(void)

{
@@ -252,6 +317,44 @@ test_idxd_validate_dif_check_buf_align(void) 
	CU_ASSERT(rc == -EINVAL);

}



static void

test_idxd_validate_dif_insert_buf_align(void)

{

	struct spdk_dif_ctx dif_ctx;

	struct spdk_dif_ctx_init_ext_opts dif_opts;

	int rc;



	dif_opts.size = SPDK_SIZEOF(&dif_opts, dif_pi_format);

	dif_opts.dif_pi_format = SPDK_DIF_PI_FORMAT_16;



	rc = spdk_dif_ctx_init(&dif_ctx,

			       512 + 8,

			       8,

			       true,

			       false,

			       SPDK_DIF_TYPE1,

			       SPDK_DIF_FLAGS_GUARD_CHECK | SPDK_DIF_FLAGS_APPTAG_CHECK |

			       SPDK_DIF_FLAGS_REFTAG_CHECK,

			       0, 0, 0, 0, 0, &dif_opts);

	CU_ASSERT(rc == 0);



	/* The memory source and destination buffer length set correctly */

	rc = idxd_validate_dif_insert_buf_align(&dif_ctx, 4 * 512, 4 * 520);

	CU_ASSERT(rc == 0);



	/* The memory source buffer length is not a multiple of block size without metadata */

	rc = idxd_validate_dif_insert_buf_align(&dif_ctx, 4 * 512 + 10, 4 * 520);

	CU_ASSERT(rc == -EINVAL);



	/* The memory destination buffer length is not a multiple of block size with metadata */

	rc = idxd_validate_dif_insert_buf_align(&dif_ctx, 4 * 512, 4 * 520 + 10);

	CU_ASSERT(rc == -EINVAL);



	/* The memory source and destiantion must hold the same number of blocks */

	rc = idxd_validate_dif_insert_buf_align(&dif_ctx, 4 * 512, 5 * 520);

	CU_ASSERT(rc == -EINVAL);

}



static void

test_idxd_get_dif_flags(void)

{
@@ -443,6 +546,8 @@ main(int argc, char **argv) 
	CU_ADD_TEST(suite, test_idxd_validate_dif_common_params);

	CU_ADD_TEST(suite, test_idxd_validate_dif_check_params);

	CU_ADD_TEST(suite, test_idxd_validate_dif_check_buf_align);

	CU_ADD_TEST(suite, test_idxd_validate_dif_insert_params);

	CU_ADD_TEST(suite, test_idxd_validate_dif_insert_buf_align);

	CU_ADD_TEST(suite, test_idxd_get_dif_flags);

	CU_ADD_TEST(suite, test_idxd_get_source_dif_flags);

	CU_ADD_TEST(suite, test_idxd_get_app_tag_mask);