Commit 0ed1f4f8 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

bdev: fix size comparison when getting ext_io_opts 



We should use the size of the structure as passed by the user and not
sizeof(*opts), which will always be true.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Icd46cd5d7ad5ce8b74731369a5215b7084a7f32a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18445


Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
parent 1b1967bd

lib/bdev/bdev.c

+1 −1
Original line number Diff line number Diff line
@@ -425,7 +425,7 @@ static void bdev_ch_retry_io(struct spdk_bdev_channel *bdev_ch); 


#define bdev_get_ext_io_opt(opts, field, defval) \

	(((opts) != NULL && offsetof(struct spdk_bdev_ext_io_opts, field) + \

	 sizeof((opts)->field) <= sizeof(*(opts))) ? (opts)->field : (defval))

	 sizeof((opts)->field) <= (opts)->size) ? (opts)->field : (defval))



void

spdk_bdev_get_opts(struct spdk_bdev_opts *opts, size_t opts_size)