Commit 0e9ee176 authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

posix: Fix the NULL pointer issue of group. 



A single sock connection can call posix_sock_flush,
and this sock may not belong to a polling group.
So add the check in sock_check_zcopy to avoid such issue.

Fixes #1788

Change-Id: Id0a2f80ad0f3cdb7fc736a3be3211e49513751b1
Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6334


Reviewed-by: default avatar <dongx.yi@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent 8654a1b0

module/sock/posix/posix.c

+1 −1
Original line number Diff line number Diff line
@@ -724,7 +724,7 @@ _sock_check_zcopy(struct spdk_sock *sock) 


			/* If we reaped buffer reclaim notification and sock is not in pending_recv list yet,

			 * add it now. It allows to call socket callback and process completions */

			if (found && !psock->pending_recv) {

			if (found && !psock->pending_recv && group) {

				psock->pending_recv = true;

				TAILQ_INSERT_TAIL(&group->pending_recv, psock, link);

			}