Commit 0db73d09 authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Tomasz Zawadzki
Browse files

test/lvol: Fix - improve checking failed commands 



Instead of using "!" use rpc_cmd && false to check
that command should fail but succeded

Change-Id: Ied564c13b96ea6d4a45aab1460b3323edd1d9554
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478328


Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
parent 5e358080

test/lvol/basic.sh

+5 −5
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ function test_construct_lvs() { 


	# remove it and verify it's gone

	rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid"

	! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid"

	rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false

	rpc_cmd bdev_malloc_delete "$malloc_name"

	check_leftover_devices

}
@@ -50,7 +50,7 @@ function test_construct_lvol() { 


	# clean up and create another lvol, this time use lvs alias instead of uuid

	rpc_cmd bdev_lvol_delete "$lvol_uuid"

	! rpc_cmd bdev_get_bdevs -b "$lvol_uuid"

	rpc_cmd bdev_get_bdevs -b "$lvol_uuid" && false

	lvol_uuid=$(rpc_cmd bdev_lvol_create -l lvs_test lvol_test "$LVS_DEFAULT_CAPACITY_MB")

	lvol=$(rpc_cmd bdev_get_bdevs -b "$lvol_uuid")
@@ -63,9 +63,9 @@ function test_construct_lvol() { 


	# clean up

	rpc_cmd bdev_lvol_delete "$lvol_uuid"

	! rpc_cmd bdev_get_bdevs -b "$lvol_uuid"

	rpc_cmd bdev_get_bdevs -b "$lvol_uuid" && false

	rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid"

	! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid"

	rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false

	rpc_cmd bdev_malloc_delete "$malloc_name"

	check_leftover_devices

}
@@ -127,7 +127,7 @@ function test_construct_multi_lvols() { 
	[ "$(jq length <<< "$lvols")" == "0" ]



	rpc_cmd bdev_lvol_delete_lvstore -u "$lvs_uuid"

	! rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid"

	rpc_cmd bdev_lvol_get_lvstores -u "$lvs_uuid" && false

	rpc_cmd bdev_malloc_delete "$malloc_name"

	check_leftover_devices

}