Commit 0d8f86f8 authored Jul 16, 2020 by Seth Howell Committed by Tomasz Zawadzki Jul 31, 2020

lib/nvme: don't submit request if qpair is disconnected.



This becomes a problem when the qpair is reconnected.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I6677b396cf766684a4891ffbee93aa3e4e83374d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3391


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 612aa86b

lib/nvme/nvme_qpair.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -826,6 +826,10 @@ _nvme_qpair_submit_request(struct spdk_nvme_qpair qpair, struct nvme_request r

		nvme_qpair_check_enabled(qpair);

		if (nvme_qpair_get_state(qpair) == NVME_QPAIR_DISCONNECTED) {
		return -ENXIO;
		}

		if (req->num_children) {
		/*
		* This is a split (parent) request. Submit all of the children but not the parent

test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -111,6 +111,7 @@ test3(void)
		struct nvme_request *req;
		struct spdk_nvme_ctrlr ctrlr = {};

		qpair.state = NVME_QPAIR_ENABLED;
		prepare_submit_request_test(&qpair, &ctrlr);

		req = nvme_allocate_request_null(&qpair, expected_success_callback, NULL);