Commit 0d3ad999 authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Tomasz Zawadzki
Browse files

sock/posix: Don't return if zcopy is disabled 



When socket is being created and zcopy is disabled
by the config, we can return from posix_sock_alloc
function before we try to set quick_ack

Signed-off-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Change-Id: I6670b8337e70ec12b18a5e6753674fbef9e95648
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6382


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 04474fec

module/sock/posix/posix.c

+7 −9
Original line number Diff line number Diff line
@@ -2,7 +2,7 @@ 
 *   BSD LICENSE

 *

 *   Copyright (c) Intel Corporation. All rights reserved.

 *   Copyright (c) 2020 Mellanox Technologies LTD. All rights reserved.

 *   Copyright (c) 2020, 2021 Mellanox Technologies LTD. All rights reserved.

 *

 *   Redistribution and use in source and binary forms, with or without

 *   modification, are permitted provided that the following conditions
@@ -327,15 +327,13 @@ posix_sock_alloc(int fd, bool enable_zero_copy) 
#if defined(SPDK_ZEROCOPY)

	flag = 1;



	if (!enable_zero_copy || !g_spdk_posix_sock_impl_opts.enable_zerocopy_send) {

		return sock;

	}



	if (enable_zero_copy && g_spdk_posix_sock_impl_opts.enable_zerocopy_send) {

		/* Try to turn on zero copy sends */

		rc = setsockopt(sock->fd, SOL_SOCKET, SO_ZEROCOPY, &flag, sizeof(flag));

		if (rc == 0) {

			sock->zcopy = true;

		}

	}

#endif



#if defined(__linux__)