Commit 0d33baa1 authored by Vitaliy Mysak's avatar Vitaliy Mysak Committed by Darek Stojaczyk
Browse files

test/spdkcli: test start_subsystem_init command 

Add an invocation of `start_subsystem_init` method of spdkcli to iscsi test.
This method is one of few that left untested in spdkcli.

iscsi test had to be changed a bit because `start_subsystem_init` requires
  spdk to be started with `--wait-for-rpc`.

This patch is related to trello task:
https://trello.com/c/CHOOxcGj/151-spdkcli-extend-test-coverage



Change-Id: I4f49f2ce499ef849d4d41a391844f5947c1b133d
Signed-off-by: default avatarVitaliy Mysak <vitaliy.mysak@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462213


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
parent 60bf34d1

test/spdkcli/common.sh

+0 −6
Original line number Diff line number Diff line
@@ -32,12 +32,6 @@ function run_nvmf_tgt() { 
	waitforlisten $nvmf_tgt_pid

}



function run_iscsi_tgt() {

	$rootdir/app/iscsi_tgt/iscsi_tgt -m 0x3 -p 0 -s 4096 &

	iscsi_tgt_pid=$!

	waitforlisten $iscsi_tgt_pid

}



function run_vhost_tgt() {

	$rootdir/app/vhost/vhost -m 0x3 -p 0 -s 4096 &

	vhost_tgt_pid=$!

test/spdkcli/iscsi.sh

+7 −1
Original line number Diff line number Diff line
@@ -13,7 +13,13 @@ timing_enter spdkcli_iscsi 
trap 'on_error_exit;' ERR



timing_enter run_iscsi_tgt

run_iscsi_tgt



# Running iscsi target with --wait-for-rpc. Implies start_subsystem_init later

$rootdir/app/iscsi_tgt/iscsi_tgt -m 0x3 -p 0 -s 4096 --wait-for-rpc &

iscsi_tgt_pid=$!

waitforlisten $iscsi_tgt_pid

$rootdir/scripts/rpc.py start_subsystem_init



timing_exit run_iscsi_tgt



timing_enter spdkcli_create_iscsi_config