Commit 0ce6762b authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

spdk_top: redraw tabs after exiting popups 



Adds the following after exiting popups:
-redrawing tab menu
-tab and core window refresh after closing thread pop-up
-update_panels() to refresh column names and lines
-redrawing tab contents

The goal of this patch is purely to improve visual
aspects of spdk_top.

Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Change-Id: I16952b75dd8e79521a41a8c2bda6fa62d43ccec8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7397


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent fb558e0d

app/spdk_top/spdk_top.c

+18 −0
Original line number Diff line number Diff line
@@ -2577,6 +2577,13 @@ show_core(uint8_t current_page, uint8_t active_tab) 
			if (thread_id != 0) {

				show_single_thread(thread_id, current_page, active_tab, core_win, core_info);

			}



			/* This refreshes tab and core_pop-up after exiting threads pop-up. */

			pthread_mutex_lock(&g_thread_lock);

			refresh_tab(active_tab, current_page);

			wnoutrefresh(core_win);

			refresh();

			pthread_mutex_unlock(&g_thread_lock);

			break;

		case 27: /* ESC */

			stop_loop = true;
@@ -2998,6 +3005,17 @@ show_stats(pthread_t *data_thread) 
			} else if (active_tab == POLLERS_TAB) {

				show_poller(current_page, active_tab);

			}

			/* After closing pop-up there would be unrefreshed parts

			 * of the tab, so this is to refresh them */

			draw_tabs(active_tab, g_current_sort_col[active_tab], g_current_sort_col2[active_tab]);

			pthread_mutex_lock(&g_thread_lock);

			max_pages = refresh_tab(active_tab, current_page);

			pthread_mutex_unlock(&g_thread_lock);

			snprintf(current_page_str, CURRENT_PAGE_STR_LEN - 1, "Page: %d/%d", current_page + 1, max_pages);

			mvprintw(g_max_row - 1, 1, "%s", current_page_str);

			top_panel(g_panels[active_tab]);

			update_panels();

			refresh();

			break;

		case 'h':

			help_window_display();