Commit 0c471fd6 authored by Dariusz Stojaczyk's avatar Dariusz Stojaczyk Committed by Jim Harris
Browse files

vhost_scsi: enable VIRTIO_SCSI_F_CHANGE flag 



As of virtio spec 1.0, driver must not accept flags which the device
did not offer (section 2.2). However, that flag is apparently being
accepted, causing silent exception to be triggered in rte_vhost. This
results in all negotiated features to be rejected in rte_vhost.

This patch is a workaround. Enabling that flag does not enforce us to do
any additional actions.

Change-Id: Iede0c0360de33d438f109442c7a83231e9d4479e
Signed-off-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/365806


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 5160ffaf

lib/vhost/vhost_scsi.c

+0 −2
Original line number Diff line number Diff line
@@ -58,11 +58,9 @@ 


/* Features that are specified in VIRTIO SCSI but currently not supported:

 * - Live migration not supported yet

 * - LUN params change

 * - T10 PI

 */

#define SPDK_VHOST_SCSI_DISABLED_FEATURES	((1ULL << VHOST_F_LOG_ALL) | \

						(1ULL << VIRTIO_SCSI_F_CHANGE ) | \

						(1ULL << VIRTIO_SCSI_F_T10_PI ))



#define MGMT_POLL_PERIOD_US (1000 * 5)