Commit 0bde7708 authored by liupan1111's avatar liupan1111 Committed by Daniel Verkamp
Browse files

Fix some cppcheck errors on lib/iscsi & lib/scsi. (#41) 

 Fixed error types:
 1 nullPointerRedundantCheck;
 2 unsignedLessThanZero;
 4 invalidPrintfArgType_sint;
 5 arrayIndexThenCheck
parent e445f16b

lib/iscsi/conn.c

+1 −2
Original line number Diff line number Diff line
@@ -386,7 +386,6 @@ spdk_iscsi_conn_construct(struct spdk_iscsi_portal *portal, 
		SPDK_ERRLOG("iscsi_conn_params_init() failed\n");

error_return:

		spdk_iscsi_param_free(conn->params);

		if (conn)

		free_conn(conn);

		return -1;

	}

lib/iscsi/iscsi_subsystem.c

+33 −35
Original line number Diff line number Diff line
@@ -276,7 +276,6 @@ spdk_iscsi_config_dump_target_nodes(FILE *fp) 
				target->map[m].ig->tag);

		}



		if (dev) {

		const char *authmethod = "None";

		char authgroup[32] = "None";

		const char *usedigest = "Auto";
@@ -313,7 +312,6 @@ spdk_iscsi_config_dump_target_nodes(FILE *fp) 
			target->queue_depth);

	}

}

}



static void

spdk_mobj_ctor(struct rte_mempool *mp, __attribute__((unused)) void *arg,

lib/iscsi/md5.c

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ int spdk_md5update(struct spdk_md5ctx *md5ctx, const void *data, size_t len) 


	if (md5ctx == NULL)

		return -1;

	if (data == NULL || len <= 0)

	if (data == NULL || len == 0)

		return 0;

	rc = MD5_Update(&md5ctx->md5ctx, data, len);

	return rc;

lib/scsi/scsi_bdev.c

+2 −1
Original line number Diff line number Diff line
@@ -66,7 +66,8 @@ spdk_bdev_scsi_set_local_naa(char *name, uint8_t *buf) 
{

	int i, value, count = 0;

	uint64_t naa, local_value;

	for (i = 0; (name[i] != '\0') && (i < 16); i++) {



	for (i = 0; (i < 16) && (name[i] != '\0'); i++) {

		value = spdk_hex2bin(name[i]);

		if (i % 2) {

			buf[count++] |= value << 4;

test/lib/bdev/bdevperf/bdevperf.c

+1 −1
Original line number Diff line number Diff line
@@ -440,7 +440,7 @@ performance_dump(int io_time) 
		target = head[index];

		if (target != NULL) {

			lcore_id = target->lcore;

			printf("\r Logical core: %d\n", lcore_id);

			printf("\r Logical core: %u\n", lcore_id);

		}

		while (target != NULL) {

			io_per_second = (float)target->io_completed /