Commit 0badf81e authored by Jim Harris's avatar Jim Harris
Browse files

bdev: remove deprecated spdk_bdev_module_finish_done() 



For reference, this was deprecated in Aug 2020, commit
ID 511fe155.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ic0a16af9113b8b136271a2ce6a071bbc379261c4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11545


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent 5d2d2531

CHANGELOG.md

+4 −0
Original line number Diff line number Diff line
@@ -2,6 +2,10 @@ 


## v22.05: (Upcoming Release)



### bdev



Removed deprecated spdk_bdev_module_finish_done(). Use spdk_bdev_module_fini_done() instead.



### bdev_nvme



Added `bdev_nvme_add_error_injection` and `bdev_nvme_remove_error_injection` RPCs to add and

deprecation.md

+0 −5
Original line number Diff line number Diff line
@@ -14,11 +14,6 @@ ABI cannot be removed without providing deprecation notice for at least single S 


## Deprecation Notices {#deprecation-notices}



### bdev



Deprecated `spdk_bdev_module_finish_done()` API, which will be removed in SPDK 22.01.

Bdev modules should use `spdk_bdev_module_fini_done()` instead.



### nvme



Deprecated `spdk_nvme_ctrlr_reset_async` and `spdk_nvme_ctrlr_reset_poll_async` APIs,

include/spdk/bdev_module.h

+0 −1
Original line number Diff line number Diff line
@@ -843,7 +843,6 @@ void spdk_bdev_module_init_done(struct spdk_bdev_module *module); 
 *

 */

void spdk_bdev_module_fini_done(void);

void spdk_bdev_module_finish_done(void); /* Deprecated */



/**

 * Indicate that the module fini start has completed.

lib/bdev/bdev.c

+0 −8
Original line number Diff line number Diff line
@@ -1635,14 +1635,6 @@ spdk_bdev_module_fini_done(void) 
	}

}



/* Deprecated */

void

spdk_bdev_module_finish_done(void)

{

	SPDK_NOTICELOG("spdk_bdev_module_finish_done() is deprecated, please use spdk_bdev_module_fini_done().\n");

	spdk_bdev_module_fini_done();

}



static void

bdev_finish_unregister_bdevs_iter(void *cb_arg, int bdeverrno)

{

lib/bdev/spdk_bdev.map

+0 −1
Original line number Diff line number Diff line
@@ -105,7 +105,6 @@ 
	spdk_bdev_module_examine_done;

	spdk_bdev_module_init_done;

	spdk_bdev_module_fini_done;

	spdk_bdev_module_finish_done;

	spdk_bdev_module_fini_start_done;

	spdk_bdev_module_claim_bdev;

	spdk_bdev_module_release_bdev;