Commit 0ac493f5 authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Darek Stojaczyk
Browse files

test: Shellcheck - ignore SC1090 and SC1091 warnings 



Add to pernamently excluded in shellcheck:
	*SC1090: Can't follow non-constant source. Use a directive to specify location.
	*SC1091: Not following: (error message here)
We don't want to put commnets in lines where we refer to some sources.

Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: Ida7a8924901649d270ed5384677ee23f206da9f1
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469870


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
parent 6f442e50

scripts/check_format.sh

+7 −1
Original line number Diff line number Diff line
@@ -239,8 +239,9 @@ if hash shellcheck 2>/dev/null; then 
	# For more information about the topic and a list of human-friendly error descripions

	# go to: https://trello.com/c/29Z90j1W

	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1001,SC1003,SC1010,\

SC1083,SC1090,SC1091,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,\

SC1083,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,\

SC2010,SC2012,SC2013,SC2015,SC2016,SC2018,SC2019,SC2022,\

SC2027,SC2030,SC2031,SC2034,SC2035,SC2039,SC2043,SC2044,SC2045,SC2046,\

SC2068,SC2086,SC2089,SC2090,SC2094,\
@@ -252,6 +253,11 @@ SC2206,SC2207,SC2214,SC2223,SC2230,SC2231" 
	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1117"

	# SPDK has decided to not fix violations of these errors.

	# We are aware about below exclude list and we want this errors to be excluded.

	# SC1090: Can't follow non-constant source. Use a directive to specify location.

	# SC1091: Not following: (error message here)

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091"



	SHCK_FORMAT="diff"

	SHCK_APPLY=true