Commit 0aa72ffb authored by Jim Harris's avatar Jim Harris
Browse files

nvme: fix WRITE_TO_RO_RANGE status code 



WRITE_TO_RO_PAGE was incorrect and misleading.  This
0x82 NVMe status code indicates a write to a read-only
range of LBAs.  So modify the constant name and
associated usages to use WRITE_TO_RO_RANGE instead.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I993dbebb5acc2e685a0e99aa14084942ef79d659
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465083


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 87b7f286

include/spdk/nvme_spec.h

+1 −1
Original line number Diff line number Diff line
@@ -654,7 +654,7 @@ enum spdk_nvme_command_specific_status_code { 


	SPDK_NVME_SC_CONFLICTING_ATTRIBUTES		= 0x80,

	SPDK_NVME_SC_INVALID_PROTECTION_INFO		= 0x81,

	SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_PAGE		= 0x82,

	SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_RANGE	= 0x82,

};



/**

lib/bdev/scsi_nvme.c

+1 −1
Original line number Diff line number Diff line
@@ -158,7 +158,7 @@ spdk_scsi_nvme_translate(const struct spdk_bdev_io *bdev_io, int *sc, int *sk, 
			*asc  = SPDK_SCSI_ASC_INVALID_FIELD_IN_CDB;

			*ascq = SPDK_SCSI_ASCQ_CAUSE_NOT_REPORTABLE;

			break;

		case SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_PAGE:

		case SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_RANGE:

			*sc   = SPDK_SCSI_STATUS_CHECK_CONDITION;

			*sk   = SPDK_SCSI_SENSE_DATA_PROTECT;

			*asc  = SPDK_SCSI_ASC_WRITE_PROTECTED;

lib/nvme/nvme_qpair.c

+1 −1
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ static const struct nvme_string command_specific_status[] = { 
	{ SPDK_NVME_SC_INVALID_RESOURCE_ID, "INVALID RESOURCE IDENTIFIER" },

	{ SPDK_NVME_SC_CONFLICTING_ATTRIBUTES, "CONFLICTING ATTRIBUTES" },

	{ SPDK_NVME_SC_INVALID_PROTECTION_INFO, "INVALID PROTECTION INFO" },

	{ SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_PAGE, "WRITE TO RO PAGE" },

	{ SPDK_NVME_SC_ATTEMPTED_WRITE_TO_RO_RANGE, "WRITE TO RO RANGE" },

	{ 0xFFFF, "COMMAND SPECIFIC" }

};