Commit 09c0c976 authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

nvmf: return feature not changeable for Interrupt Coalescing feature 



Windows will always sends a Set Feature Interrupt Coalescing even
SPDK reports we can't support it in Get Feature command.  Here
we return Feature Not Changeable instead of Invalid Field which
is more meaningful.

Change-Id: Ie08086c3eba1e2d790a7ae4976653b6f9085028c
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8923


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent a6e95347

lib/nvmf/ctrlr.c

+4 −0
Original line number Diff line number Diff line
@@ -2912,6 +2912,10 @@ nvmf_ctrlr_set_features(struct spdk_nvmf_request *req) 
		return nvmf_ctrlr_set_features_volatile_write_cache(req);

	case SPDK_NVME_FEAT_NUMBER_OF_QUEUES:

		return nvmf_ctrlr_set_features_number_of_queues(req);

	case SPDK_NVME_FEAT_INTERRUPT_COALESCING:

		response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC;

		response->status.sc = SPDK_NVME_SC_FEATURE_NOT_CHANGEABLE;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;

	case SPDK_NVME_FEAT_WRITE_ATOMICITY:

		return nvmf_ctrlr_set_features_write_atomicity(req);

	case SPDK_NVME_FEAT_ASYNC_EVENT_CONFIGURATION: