Commit 09a782dc authored May 07, 2019 by Richael Zhuang Committed by Jim Harris May 08, 2019

sock: fix a uninitialized-variable error



Valgrind reports error "epoll_ctl(event) points to uninitiazlized
byte(s)" when running unit test. Fix it by initializing variable event
to a known state.

Change-Id: I756687c1077eeb632c045c316a76714aa453b918
Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453525


Reviewed-by: wuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent fa0005d4

lib/sock/posix/posix.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -506,6 +506,7 @@ spdk_posix_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct
		#if defined(__linux__)
		struct epoll_event event;

		memset(&event, 0, sizeof(event));
		event.events = EPOLLIN;
		event.data.ptr = sock;

lib/sock/vpp/vpp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -557,6 +557,7 @@ spdk_vpp_sock_group_impl_add_sock(struct spdk_sock_group_impl *_group, struct sp
		assert(group != NULL);
		assert(g_vpp_initialized);

		memset(&event, 0, sizeof(event));
		event.events = EPOLLIN;
		event.data.ptr = sock;