Commit 08278bf9 authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Jim Harris
Browse files

test: Shellcheck - apply rule SC1010. 



Use semicolon or linefeed before 'done' (or quote to make it literal).

Change-Id: I90c01e643fae41dd9961f2314a076a0bac1e6aff
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466904


Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 54a493de

scripts/check_format.sh

+1 −1
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ if hash shellcheck 2>/dev/null; then 
	# go to: https://trello.com/c/29Z90j1W

	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1001,SC1003,SC1010,\

	SHCK_EXCLUDE="SC1001,SC1003,\

SC1083,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,\

SC2010,SC2012,SC2013,SC2016,\

SC2034,SC2043,SC2044,SC2045,SC2046,\

test/iscsi_tgt/common.sh

+2 −0
Original line number Diff line number Diff line
@@ -176,6 +176,8 @@ function start_vpp() { 
	ip addr show $INITIATOR_INTERFACE

	ip netns exec $TARGET_NAMESPACE ip addr show $TARGET_INTERFACE

	sleep 3

	# SC1010: ping -M do - in this case do is an option not bash special word

	# shellcheck disable=SC1010

	ping -c 1 $TARGET_IP -s $(( $MTU - 28 )) -M do

	vppctl ping $INITIATOR_IP repeat 1 size $(( $MTU - (28 + 8) )) verbose

}