Commit 072f3706 authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

thread: remove pointless ->set_intr_cb_fn check 



poller_set_interrupt_mode() only can be called when
spdk_interrupt_mode_is_enabled() is true. But when
spdk_interrupt_mode_is_enabled() is true, we also know that
all pollers will have their set_intr_cb_fn set:

- spdk_poller_register() will set a default ->set_intr_cb_fn when
  spdk_interrupt_mode_is_enabled() == true
- if spdk_poller_register_interrupt() is later called on that poller,
  it must specify a ->set_intr_cb_fn

So checking poller->set_intr_cb_fn in poller_set_interrupt_mode()
is pointless, it will always be set.

If we want to have warnings for cases where interrupt mode is
enabled, but there are busy pollers that haven't been registered for
interrupts, we need some other mechanism. Remove this mechanism that
seemed to be trying to do this, but clearly doesn't.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I033f31269e896a7c6b22a8c065b229e289510271
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24625


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Reviewed-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarKrzysztof Goreczny <krzysztof.goreczny@dell.com>
parent 47d1bc80

lib/thread/thread.c

+0 −6
Original line number Diff line number Diff line
@@ -2078,12 +2078,6 @@ poller_set_interrupt_mode(struct spdk_poller *poller, bool interrupt_mode) 
		return;

	}



	if (!poller->set_intr_cb_fn) {

		SPDK_ERRLOG("Poller(%s) doesn't support set interrupt mode.\n", poller->name);

		assert(false);

		return;

	}



	poller->set_intr_cb_fn(poller, poller->set_intr_cb_arg, interrupt_mode);

}