Commit 0616beb5 authored by Artur Paszkiewicz's avatar Artur Paszkiewicz Committed by Konrad Sztyber
Browse files

scripts/check_format: further limit astyle versions 



Only allow astyle versions between 3.0.1 and 3.1. Other versions cause
formatting changes in existing code.

Signed-off-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I998f083749374e4d7061c522108f33a82a3869f2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24217


Reviewed-by: default avatarMichal Berger <michal.berger@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent cd6a5d97

scripts/check_format.sh

+2 −5
Original line number Diff line number Diff line
@@ -131,11 +131,8 @@ function check_c_style() { 
	if hash astyle; then

		echo -n "Checking coding style..."

		version=$(astyle --version | awk '{print $NF}')

		if lt "$version" 3.0.1; then

			echo " Your astyle version is too old so skipping coding style checks. Please update astyle to at least 3.0.1 version..."

			rc=1

		elif ge "$version" 3.4; then

			echo " Your astyle version is too new so skipping coding style checks. Please use astyle version < 3.4"

		if lt "$version" 3.0.1 || gt "$version" 3.1; then

			echo " Your astyle version is not compatible so skipping coding style checks. Please use astyle version between 3.0.1 and 3.1"

			rc=1

		else

			rm -f astyle.log