Commit 0574f36d authored by Karol Latecki's avatar Karol Latecki Committed by Tomasz Zawadzki
Browse files

scripts/nvmf_perf: improve error handling 



Add exceptions to results parsing and fio run functions
to better inform what's the cause of the failure.

Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Change-Id: I94e51cb8f77515f7d26a75501011d6111820ae56
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8742


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 2c8baa46

scripts/perf/nvmf/run_nvmf.py

+15 −7
Original line number Diff line number Diff line 
#!/usr/bin/env python3



from json.decoder import JSONDecodeError

import os

import re

import sys
@@ -524,9 +525,12 @@ class Target(Server): 


                separate_stats = []

                for r in i_results:

                    try:

                        stats = self.read_json_stats(os.path.join(results_dir, r))

                        separate_stats.append(stats)

                        self.log_print(stats)

                    except JSONDecodeError as e:

                        self.log_print("ERROR: Failed to parse %s results! Results might be incomplete!")



                init_results = [sum(x) for x in zip(*separate_stats)]

                init_results = [x / len(separate_stats) for x in init_results]
@@ -886,10 +890,14 @@ registerfiles=1 
        if run_num:

            for i in range(1, run_num + 1):

                output_filename = job_name + "_run_" + str(i) + "_" + self.name + ".json"

                try:

                    output = self.exec_cmd(["sudo", self.fio_bin,

                                            fio_config_file, "--output-format=json",

                                            "--output=%s" % output_filename], True)

                    self.log_print(output)

                except subprocess.CalledProcessError as e:

                    self.log_print("ERROR: Fio process failed!")

                    self.log_print(e.stdout)

        else:

            output_filename = job_name + "_" + self.name + ".json"

            output = self.exec_cmd(["sudo", self.fio_bin,