Commit 04d14898 authored Aug 26, 2024 by Jim Harris Committed by Konrad Sztyber Sep 05, 2024

test/unit/iscsi: initialize task.scsi.iov.iov_base in more places



Newer ubsan doesn't like adding a zero offset to a NULL pointer, so
initialize the iov_base in this unit test to avoid it. An earlier
patch fixed this in one place, but there are a couple of others
that were missed.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If55ca2f582760b5752ac578f25d4735d8d677f5e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24727


Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>

parent b0ca75fc

test/unit/lib/iscsi/iscsi.c/iscsi_ut.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -516,6 +516,7 @@ underflow_for_request_sense_test(void)
		iscsi_task_set_pdu(&task, pdu1);
		task.parent = NULL;

		task.scsi.iov.iov_base = (void *)0xF000000;
		task.scsi.iovs = &task.scsi.iov;
		task.scsi.iovcnt = 1;
		task.scsi.length = 512;
		@@ -607,6 +608,7 @@ underflow_for_check_condition_test(void)
		iscsi_task_set_pdu(&task, pdu);
		task.parent = NULL;

		task.scsi.iov.iov_base = (void *)0xF0000000;
		task.scsi.iovs = &task.scsi.iov;
		task.scsi.iovcnt = 1;
		task.scsi.length = 512;