Commit 040095db authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

lib/iscsi: Remove unimplemented internal API from tgt_node.h 



spdk_iscsi_tgt_node_reset() is not implemented and the code to
call it is commented out. We will have to implement them from scratch
if we do. So remove them in this patch.

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I63618b0f8857cb23b57f5a92ec363a91c1d5a912
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1885


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell@intel.com>
parent 356cb233

lib/iscsi/iscsi.c

+1 −22
Original line number Diff line number Diff line
@@ -3718,33 +3718,12 @@ iscsi_pdu_hdr_op_task(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu) 


	case ISCSI_TASK_FUNC_TARGET_WARM_RESET:

		SPDK_NOTICELOG("TARGET_WARM_RESET (Unsupported)\n");



#if 0

		spdk_iscsi_drop_conns(conn, conn->initiator_name, 1 /* drop all */);

		rc = spdk_iscsi_tgt_node_reset(conn->sess->target, lun);

		if (rc < 0) {

			SPDK_ERRLOG("tgt_node reset failed\n");

		}

#else

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

#endif

		break;



	case ISCSI_TASK_FUNC_TARGET_COLD_RESET:

		SPDK_NOTICELOG("TARGET_COLD_RESET\n");



#if 0

		spdk_iscsi_drop_conns(conn, conn->initiator_name, 1 /* drop all */);



		rc = spdk_iscsi_tgt_node_reset(conn->sess->target, lun);

		if (rc < 0) {

			SPDK_ERRLOG("tgt_node reset failed\n");

		}



		conn->state = ISCSI_CONN_STATE_EXITING;

#else

		SPDK_NOTICELOG("TARGET_COLD_RESET (Unsupported)\n");

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

#endif

		break;



	case ISCSI_TASK_FUNC_TASK_REASSIGN:

lib/iscsi/tgt_node.h

+0 −2
Original line number Diff line number Diff line
@@ -132,8 +132,6 @@ bool spdk_iscsi_tgt_node_access(struct spdk_iscsi_conn *conn, 
				struct spdk_iscsi_tgt_node *target, const char *iqn,

				const char *addr);

struct spdk_iscsi_tgt_node *spdk_iscsi_find_tgt_node(const char *target_name);

int spdk_iscsi_tgt_node_reset(struct spdk_iscsi_tgt_node *target,

			      uint64_t lun);

int spdk_iscsi_tgt_node_cleanup_luns(struct spdk_iscsi_conn *conn,

				     struct spdk_iscsi_tgt_node *target);

void spdk_iscsi_tgt_node_delete_map(struct spdk_iscsi_portal_grp *portal_group,