Commit 038fb903 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

bdev: Move down RPC parameters and decoders for bdev_get_iostat RPC 



RPC parameters and decoders for the bdev_get_iostat RPC are used only
by rpc_bdev_get_iostat(). Locating RPC parameters and decoders close to
rpc_bdev_get_iostat() clarifies it. Furthermore, this will simplify code
review for the next patch.

Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I1b1b428e3eb3bb4422e490c5f4324f0e40f9710f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15416


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 0ac95a68

lib/bdev/bdev_rpc.c

+16 −16
Original line number Diff line number Diff line
@@ -277,22 +277,6 @@ done: 
	free(_stat);

}



struct rpc_bdev_get_iostat {

	char *name;

	bool per_channel;

};



static void

free_rpc_bdev_get_iostat(struct rpc_bdev_get_iostat *r)

{

	free(r->name);

}



static const struct spdk_json_object_decoder rpc_bdev_get_iostat_decoders[] = {

	{"name", offsetof(struct rpc_bdev_get_iostat, name), spdk_json_decode_string, true},

	{"per_channel", offsetof(struct rpc_bdev_get_iostat, per_channel), spdk_json_decode_bool, true},

};



static int

_bdev_get_device_stat(void *_ctx, struct spdk_bdev *bdev)

{
@@ -350,6 +334,22 @@ rpc_bdev_get_per_channel_stat(struct spdk_bdev_channel_iter *i, struct spdk_bdev 
	spdk_bdev_for_each_channel_continue(i, 0);

}



struct rpc_bdev_get_iostat {

	char *name;

	bool per_channel;

};



static void

free_rpc_bdev_get_iostat(struct rpc_bdev_get_iostat *r)

{

	free(r->name);

}



static const struct spdk_json_object_decoder rpc_bdev_get_iostat_decoders[] = {

	{"name", offsetof(struct rpc_bdev_get_iostat, name), spdk_json_decode_string, true},

	{"per_channel", offsetof(struct rpc_bdev_get_iostat, per_channel), spdk_json_decode_bool, true},

};



static void

rpc_bdev_get_iostat(struct spdk_jsonrpc_request *request,

		    const struct spdk_json_val *params)