Commit 0389c9f9 authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Jim Harris
Browse files

vhost/scsi: don't send hotremove sense codes after session restart 



Always unset the VHOST_SCSI_DEV_REMOVED status on
session stop, so that we won't send hotremove SCSI
sense codes after e.g. a VM gets rebooted. The VM
should generally enumerate the SCSI devices again
in such case. We already unset the REMOVED status
for devices which were still attached at the time
of the session stop, but the devices hotremoved
before the session stop retained their REMOVED
status, giving us inconsistent behavior.

Change-Id: I7c5876e29f4bdc99cc060f1d891e24ac57051f37
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449709


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent e1c0c4c7

lib/vhost/vhost_scsi.c

+3 −2
Original line number Diff line number Diff line
@@ -1416,14 +1416,15 @@ destroy_session_poller_cb(void *arg) 
		enum spdk_scsi_dev_vhost_status prev_status;



		state = &svsession->scsi_dev_state[i];

		/* clear the REMOVED status so that we won't send hotremove events anymore */

		prev_status = state->status;

		state->status = VHOST_SCSI_DEV_EMPTY;

		if (state->dev == NULL) {

			continue;

		}



		spdk_scsi_dev_free_io_channels(state->dev);



		prev_status = state->status;

		state->status = VHOST_SCSI_DEV_EMPTY;

		state->dev = NULL;



		if (prev_status == VHOST_SCSI_DEV_REMOVING) {