Commit 03323b09 authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

nvme/ctrlr: Fix the invalid access of free_io_qids array. 

To fix the segment fault.

Fixes issue #1749

Reported by user: https://github.com/rdxsasha


Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Change-Id: I130d8dba04e4a3e83c22c5967507c1297a048f0b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8813


Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 111851ef

lib/nvme/nvme_ctrlr.c

+5 −1
Original line number Diff line number Diff line
@@ -4436,6 +4436,10 @@ spdk_nvme_ctrlr_free_qid(struct spdk_nvme_ctrlr *ctrlr, uint16_t qid) 
	assert(qid <= ctrlr->opts.num_io_queues);



	nvme_robust_mutex_lock(&ctrlr->ctrlr_lock);



	if (spdk_likely(ctrlr->free_io_qids)) {

		spdk_bit_array_set(ctrlr->free_io_qids, qid);

	}



	nvme_robust_mutex_unlock(&ctrlr->ctrlr_lock);

}