Commit 0303cf57 authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Tomasz Zawadzki
Browse files

lib/ftl: Remove debug check for FTL metadata 



FTL is going to abandon the requirement of VSS cache. We can remove
this check as it is no longer needed.

Change-Id: I41603b1f976c3e02839de7d78baba702ca706618
Signed-off-by: default avatarMariusz Barczak <Mariusz.Barczak@solidigmtechnology.com>
Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19600


Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 3d42be0b

lib/ftl/utils/ftl_md.c

+0 −24
Original line number Diff line number Diff line
@@ -421,22 +421,6 @@ get_bdev_io_ftl_stats_type(struct spdk_ftl_dev *dev, struct spdk_bdev_io *bdev_i 
	}

}



static void

audit_md_vss_version(struct ftl_md *md, uint64_t blocks)

{

#if defined(DEBUG)

	union ftl_md_vss *vss = md->io.md;

	/* Need to load the superblock regardless of its version */

	if (md->region->type == FTL_LAYOUT_REGION_TYPE_SB) {

		return;

	}

	while (blocks) {

		blocks--;

		assert(vss[blocks].version.md_version == md->region->current.version);

	}

#endif

}



static void

read_write_blocks_cb(struct spdk_bdev_io *bdev_io, bool success, void *arg)

{
@@ -460,7 +444,6 @@ read_write_blocks_cb(struct spdk_bdev_io *bdev_io, bool success, void *arg) 
			if (md->vss_data) {

				uint64_t vss_offset = md->io.data_offset / FTL_BLOCK_SIZE;

				vss_offset *= FTL_MD_VSS_SZ;

				audit_md_vss_version(md, blocks);

				memcpy(md->vss_data + vss_offset, md->io.md, blocks * FTL_MD_VSS_SZ);

			}

		}
@@ -575,15 +558,8 @@ io_submit(struct ftl_md *md) 
			vss_offset *= FTL_MD_VSS_SZ;

			assert(md->io.md);

			memcpy(md->io.md, md->vss_data + vss_offset, FTL_MD_VSS_SZ * blocks);

			audit_md_vss_version(md, blocks);

		}

	}

#if defined(DEBUG)

	if (md->io.md && md->io.op == FTL_MD_OP_CLEAR) {

		uint64_t blocks = spdk_min(md->io.remaining, ftl_md_xfer_blocks(md->dev));

		audit_md_vss_version(md, blocks);

	}

#endif



	read_write_blocks(md);

}