Commit 02ecb2dc authored by Fengnan Chang's avatar Fengnan Chang Committed by Jim Harris
Browse files

nvme: make submit request error handle in one place 



rc to -ENXIO and goto error, make all error handle in one place,
so it's easy to add more check in later patch.

Change-Id: I13edeef75bbf6c52e18d6b94b78c2e560012bfee
Signed-off-by: default avatarFengnan Chang <changfengnan@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16004


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarXiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 6ac10828

lib/nvme/nvme_qpair.c

+3 −5
Original line number Diff line number Diff line
@@ -935,11 +935,9 @@ _nvme_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *r 
			nvme_request_free_children(child_req);

			nvme_free_request(child_req);

		}

		if (req->parent != NULL) {

			nvme_request_remove_child(req->parent, req);

		}

		nvme_free_request(req);

		return -ENXIO;



		rc = -ENXIO;

		goto error;

	}



	if (req->num_children) {