Commit 004e4f6b authored by Jim Harris's avatar Jim Harris
Browse files

Fix off-by-one errors in log page fetching. 



Signed-off-by: default avatarJim Harris <james.r.harri@intel.com>
Change-Id: Iab15a1cef4ebcf4f217cbc70d716141af95367f8
parent 04b615bb

examples/nvme/identify/identify.c

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ get_health_log_page(struct nvme_controller *ctrlr) 


	cmd.opc = NVME_OPC_GET_LOG_PAGE;

	cmd.cdw10 = NVME_LOG_HEALTH_INFORMATION;

	cmd.cdw10 |= (sizeof(*health_page) / 4) << 16; // number of dwords

	cmd.cdw10 |= ((sizeof(*health_page) / 4) - 1) << 16; // number of dwords

	cmd.nsid = NVME_GLOBAL_NAMESPACE_TAG;



	return nvme_ctrlr_cmd_admin_raw(ctrlr, &cmd, health_page, sizeof(*health_page),

test/lib/nvme/aer/aer.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ get_health_log_page(struct dev *dev) 


	cmd.opc = NVME_OPC_GET_LOG_PAGE;

	cmd.cdw10 = NVME_LOG_HEALTH_INFORMATION;

	cmd.cdw10 |= (sizeof(*(dev->health_page)) / 4) << 16; // number of dwords

	cmd.cdw10 |= ((sizeof(*(dev->health_page)) / 4) - 1) << 16; // number of dwords

	cmd.nsid = NVME_GLOBAL_NAMESPACE_TAG;



	return nvme_ctrlr_cmd_admin_raw(dev->ctrlr, &cmd, dev->health_page, sizeof(*dev->health_page),