Commit 000ee408 authored by wanghailiangx's avatar wanghailiangx Committed by Jim Harris
Browse files

app module: remove support for deprecated RPC names 



These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: Ia09368e426a83274d9c7fc90ed8b0391f4d0b67c
Signed-off-by: default avatarwanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12774


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent b727e804

lib/event/app_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -111,7 +111,6 @@ invalid: 
	free_rpc_spdk_kill_instance(&req);

}

SPDK_RPC_REGISTER("spdk_kill_instance", rpc_spdk_kill_instance, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(spdk_kill_instance, kill_instance)





struct rpc_framework_monitor_context_switch {
@@ -152,7 +151,6 @@ rpc_framework_monitor_context_switch(struct spdk_jsonrpc_request *request, 


SPDK_RPC_REGISTER("framework_monitor_context_switch", rpc_framework_monitor_context_switch,

		  SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(framework_monitor_context_switch, context_switch_monitor)



struct rpc_get_stats_ctx {

	struct spdk_jsonrpc_request *request;

python/spdk/rpc/app.py

+0 −2
Original line number Diff line number Diff line 
from .helpers import deprecated_alias





@deprecated_alias('kill_instance')

def spdk_kill_instance(client, sig_name):

    """Send a signal to the SPDK process.
@@ -12,7 +11,6 @@ def spdk_kill_instance(client, sig_name): 
    return client.call('spdk_kill_instance', params)





@deprecated_alias('context_switch_monitor')

def framework_monitor_context_switch(client, enabled=None):

    """Query or set state of context switch monitoring.

scripts/rpc.py

+2 −3
Original line number Diff line number Diff line
@@ -133,8 +133,7 @@ if __name__ == "__main__": 
        rpc.app.spdk_kill_instance(args.client,

                                   sig_name=args.sig_name)



    p = subparsers.add_parser('spdk_kill_instance', aliases=['kill_instance'],

                              help='Send signal to instance')

    p = subparsers.add_parser('spdk_kill_instance', help='Send signal to instance')

    p.add_argument('sig_name', help='signal will be sent to server.')

    p.set_defaults(func=spdk_kill_instance)
@@ -147,7 +146,7 @@ if __name__ == "__main__": 
        print_dict(rpc.app.framework_monitor_context_switch(args.client,

                                                            enabled=enabled))



    p = subparsers.add_parser('framework_monitor_context_switch', aliases=['context_switch_monitor'],

    p = subparsers.add_parser('framework_monitor_context_switch',

                              help='Control whether the context switch monitor is enabled')

    p.add_argument('-e', '--enable', action='store_true', help='Enable context switch monitoring')

    p.add_argument('-d', '--disable', action='store_true', help='Disable context switch monitoring')