Skip to content
Snippets Groups Projects
Select Git revision
  • release-2025-05-15-with-patches protected
  • main default protected
  • release-2025-03-27-with-patches protected
  • release-2024-12-30-with-client-builder protected
  • release-2024-12-26-with-client-builder protected
  • release-2024-11-05-with-client-builder protected
  • release-2024-08-16-with-client-builder protected
  • release-2024-09-09-with-client-builder protected
  • release-2024-08-28-with-client-builder protected
  • release-2024-10-09-with-client-builder protected
  • sbuttgereit/expose_client_builder_with_hyper_1_0
  • release-2025-05-15
  • release-2025-05-09
  • release-2025-05-02
  • release-2025-04-23
  • release-2025-03-27
  • release-2025-03-25
  • release-2025-03-10
  • release-2025-03-04
  • release-2025-02-20
  • release-2025-02-12
  • release-2025-02-03
  • release-2025-01-28
  • release-2025-01-23
  • release-2025-01-17
  • release-2025-01-14
  • release-2024-12-30
  • release-2024-12-26
  • release-2024-12-16
  • release-2024-12-03
  • release-2024-11-05
31 results

smithy-rs

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    ysaito1001 authored
    ## Motivation and Context
    During our internal build, the `aws-sigv4` crate failed on a proptest as
    follows:
    ```
    Diff < left / right > :
    <content-length;content-type;host
    >content-length;content-type
    
    .
    minimal failing input: excluded_headers = [
        "host",
    ]
            successes: 74
            local rejects: 0
            global rejects: 0
    ', aws-sigv4/src/http_request/canonical_request.rs:838:5
    
    failures:
        http_request::canonical_request::tests::presigning_header_exclusion_with_explicit_exclusion_list_specified
    ```
    This says that `excluded_headers` should not contain `host`.
    
    To address it, this PR will filter out test inputs from proptest that
    contain `content-length`, `content-type`, or `host` (all of which appear
    in the expected value for the test at line 886 in the new revision).
    
    ## Testing
    No new tests have been added, relied on the existing tests in CI
    
    ----
    
    _By submitting this pull request, I confirm that you can use, modify,
    copy, and redistribute this contribution, under the terms of your
    choice._
    f982b40e
    History
    Name Last commit Last update