Skip to content
Snippets Groups Projects
Select Git revision
  • release-2025-05-15-with-patches protected
  • main default protected
  • release-2025-03-27-with-patches protected
  • release-2024-12-30-with-client-builder protected
  • release-2024-12-26-with-client-builder protected
  • release-2024-11-05-with-client-builder protected
  • release-2024-08-16-with-client-builder protected
  • release-2024-09-09-with-client-builder protected
  • release-2024-08-28-with-client-builder protected
  • release-2024-10-09-with-client-builder protected
  • sbuttgereit/expose_client_builder_with_hyper_1_0
  • release-2025-05-15
  • release-2025-05-09
  • release-2025-05-02
  • release-2025-04-23
  • release-2025-03-27
  • release-2025-03-25
  • release-2025-03-10
  • release-2025-03-04
  • release-2025-02-20
  • release-2025-02-12
  • release-2025-02-03
  • release-2025-01-28
  • release-2025-01-23
  • release-2025-01-17
  • release-2025-01-14
  • release-2024-12-30
  • release-2024-12-26
  • release-2024-12-16
  • release-2024-12-03
  • release-2024-11-05
31 results

smithy-rs

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    ysaito1001 authored
    * Fix panic occurred in formatting CanonicalRequest
    
    This commit addresses panic in the case of formatting a CanonicalRequest
    containing invalid UTF-8 in the header value.
    
    The commit aims for the least disturbance to the codebase in order to
    pass a given failing test in the PR. We want to quickly determine if
    this low-cost approach addresses the problem before we commit ourselves
    to start refactoring CanonicalRequest to have a special format function.
    
    Fixes #711
    
    * Update test_signing_utf8_headers to proptest
    
    This commit converts test_signing_utf8_headers to a proptest. The
    original test only specified hardcoded non-UTF8 bytes in a request
    header. To ensure that `crate::http_request::sign` does not panic no
    matter what valid byte sequence for HeaderValue is, the proptest covers
    a wider range of inputs.
    
    For consistency, the test has been moved from `canonical_request.rs` to
    `sign.rs`.
    
    * Add InvalidHeaderError to make the error explicit
    
    This commit introduces an error type InvalidHeaderError to indicate that
    we ran into a problem in handling a HeaderValue within CanonicalRequest.
    
    The error type contains a source error such as Utf8Error so a diagnostic
    message can be printed if needed.
    
    * Remove InvalidHeaderError for error refactoring
    
    This commit effectively reverts 739b32c. Knowing that we will be cleaning
    up error types, having InvalidHeaderError is too narrow a solution and
    does not add value to the codebase.
    
    * Update CHANGELOG.next.toml
    
    Co-authored-by: default avatarRussell Cohen <rcoh@amazon.com>
    Co-authored-by: default avatarSaito <awsaito@c889f3b5ddc4.ant.amazon.com>
    521fa8d0
    History
    Name Last commit Last update