Unverified Commit f0ddc666 authored by Aaron Todd's avatar Aaron Todd Committed by GitHub
Browse files

disable stalled stream protection on empty bodies and after read complete (#3644) 

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->
* https://github.com/awslabs/aws-sdk-rust/issues/1141
* https://github.com/awslabs/aws-sdk-rust/issues/1146
* https://github.com/awslabs/aws-sdk-rust/issues/1148




## Description
* Disables stalled stream upload protection for requests with an
empty/zero length body.
* Disables stalled stream upload throughput checking once the request
body has been read and handed off to the HTTP layer.


## Testing
Additional integration tests added covering empty bodies and completed
uploads.

Tested SQS issue against latest runtime and can see it works now. The S3
`CopyObject` issue is related to downloads and will need a different
solution.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: default avatarZelda Hessler <zhessler@amazon.com>
Co-authored-by: default avatarysaito1001 <awsaito@amazon.com>
parent d755bd2c

CHANGELOG.next.toml

+12 −0
Original line number Diff line number Diff line
@@ -36,6 +36,18 @@ references = ["aws-sdk-rust#1079"] 
meta = { "breaking" = false, "bug" = true, "tada" = false }

author = "rcoh"



[[aws-sdk-rust]]

message = "Fixes stalled upload stream protection to not apply to empty request bodies and to stop checking for violations once the request body has been read."

references = ["aws-sdk-rust#1141", "aws-sdk-rust#1146", "aws-sdk-rust#1148"]

meta = { "breaking" = false, "tada" = false, "bug" = true }

authors = ["aajtodd", "Velfi"]



[[smithy-rs]]

message = "Fixes stalled upload stream protection to not apply to empty request bodies and to stop checking for violations once the request body has been read."

references = ["aws-sdk-rust#1141", "aws-sdk-rust#1146", "aws-sdk-rust#1148"]

meta = { "breaking" = false, "tada" = false, "bug" = true }

authors = ["aajtodd", "Velfi"]



[[aws-sdk-rust]]

message = "Updating the documentation for the `app_name` method on `ConfigLoader` to indicate the order of precedence for the sources of the `AppName`."

references = ["smithy-rs#3645"]

rust-runtime/aws-smithy-runtime-api/Cargo.toml

+1 −1
Original line number Diff line number Diff line 
[package]

name = "aws-smithy-runtime-api"

version = "1.6.0"

version = "1.6.1"

authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Zelda Hessler <zhessler@amazon.com>"]

description = "Smithy runtime types."

edition = "2021"

rust-runtime/aws-smithy-runtime-api/src/client/stalled_stream_protection.rs

+5 −1
Original line number Diff line number Diff line
@@ -13,7 +13,11 @@ 
use aws_smithy_types::config_bag::{Storable, StoreReplace};

use std::time::Duration;



const DEFAULT_GRACE_PERIOD: Duration = Duration::from_secs(5);

/// The default grace period for stalled stream protection.

///

/// When a stream stalls for longer than this grace period, the stream will

/// return an error.

pub const DEFAULT_GRACE_PERIOD: Duration = Duration::from_secs(20);



/// Configuration for stalled stream protection.

///

rust-runtime/aws-smithy-runtime/Cargo.toml

+1 −1
Original line number Diff line number Diff line 
[package]

name = "aws-smithy-runtime"

version = "1.5.2"

version = "1.5.3"

authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Zelda Hessler <zhessler@amazon.com>"]

description = "The new smithy runtime crate"

edition = "2021"

rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput.rs

+6 −0
Original line number Diff line number Diff line
@@ -136,6 +136,10 @@ impl UploadThroughput { 
        self.logs.lock().unwrap().push_bytes_transferred(now, bytes);

    }



    pub(crate) fn mark_complete(&self) -> bool {

        self.logs.lock().unwrap().mark_complete()

    }



    pub(crate) fn report(&self, now: SystemTime) -> ThroughputReport {

        self.logs.lock().unwrap().report(now)

    }
@@ -177,6 +181,8 @@ trait UploadReport { 
impl UploadReport for ThroughputReport {

    fn minimum_throughput_violated(self, minimum_throughput: Throughput) -> (bool, Throughput) {

        let throughput = match self {

            // stream has been exhausted, stop tracking violations

            ThroughputReport::Complete => return (false, ZERO_THROUGHPUT),

            // If the report is incomplete, then we don't have enough data yet to

            // decide if minimum throughput was violated.

            ThroughputReport::Incomplete => {