Unverified Commit eea27bb3 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Add CI job to check for unused dependencies (#936) 

* Add CI job to check for unused dependencies

* Fix unused dependency in `aws-smithy-types-convert`
parent 3bf906fe

.github/workflows/ci.yaml

+38 −0
Original line number Diff line number Diff line
@@ -318,6 +318,44 @@ jobs: 
        # so we have to manually restore the target directory override

        CARGO_TARGET_DIR: ../target



  unused-sdk-dependencies:

    name: AWS Rust SDK Tier 1 - Unused dependencies

    needs: generate-sdk

    runs-on: ubuntu-latest

    steps:

    # Pinned to the commit hash of v1.3.0

    - uses: Swatinem/rust-cache@842ef286fff290e445b90b4002cc9807c3669641

      with:

        sharedKey: ${{ runner.os }}-${{ github.job }}

        target-dir: ../target

    - uses: actions-rs/toolchain@v1

      with:

        # Cargo udeps requires nightly

        toolchain: nightly

        default: true

    - name: Generate a name for the SDK

      id: gen-name

      run: echo "name=${GITHUB_REF##*/}" >> $GITHUB_ENV

    - uses: actions/download-artifact@v2

      name: Download SDK Artifact

      with:

        name: aws-sdk-${{ env.name }}-tier1-${{ github.sha }}

        path: artifact

    - name: untar

      run: mkdir aws-sdk && cd aws-sdk && tar -xvf ../artifact/sdk.tar

    - name: Install `cargo udeps`

      run: cargo install cargo-udeps

    - name: Check for unused dependencies with default features

      run: cargo udeps

      working-directory: aws-sdk

    - name: Check for unused dependencies with `--all-features`

      run: cargo udeps --all-features

      working-directory: aws-sdk

    env:

      # Note: the .cargo/config.toml is lost because we untar the SDK rather than checking out the repo,

      # so we have to manually restore the target directory override

      CARGO_TARGET_DIR: ../target



  standalone-integration-tests-check:

    name: AWS Rust SDK Standalone Integration Tests - cargo check

    needs: generate-sdk

rust-runtime/aws-smithy-types-convert/Cargo.toml

+3 −3
Original line number Diff line number Diff line
@@ -8,12 +8,12 @@ license = "Apache-2.0" 
repository = "https://github.com/awslabs/smithy-rs"



[features]

convert-chrono = ["chrono"]

convert-time = ["time"]

convert-chrono = ["aws-smithy-types", "chrono"]

convert-time = ["aws-smithy-types", "time"]

default = []



[dependencies]

aws-smithy-types = { path = "../aws-smithy-types" }

aws-smithy-types = { path = "../aws-smithy-types", optional = true }

chrono = { version = "0.4.19", optional = true }

time = { version = "0.3.4", optional = true }