Unverified Commit ee795687 authored by david-perez's avatar david-perez Committed by GitHub
Browse files

Generate `httpMalformedRequestTests` (#1213) 

Smithy defines one trait specifically for the behavior of server
protocol implementations.

From https://awslabs.github.io/smithy/1.0/spec/http-protocol-compliance-tests.html#httpmalformedrequesttests:

> The `httpMalformedRequestTests` trait is used to define how a malformed
> HTTP request is rejected given a specific protocol and HTTP message.
> Protocol implementations MUST assert that requests are rejected during
> request processing.

This commit implements code generation for these tests. The ones for the
restJson1 protocol have been added to the list of failing tests. These
should begin passing once we start implementing constraint traits
https://awslabs.github.io/smithy/1.0/spec/core/constraint-traits.html
parent b989a8d0

codegen-server-test/build.gradle.kts

+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ dependencies { 
val allCodegenTests = listOf(

    CodegenTest("com.amazonaws.simple#SimpleService", "simple"),

    CodegenTest("aws.protocoltests.restjson#RestJson", "rest_json"),

    CodegenTest("aws.protocoltests.restjson.validation#RestJsonValidation", "rest_json_validation"),

    CodegenTest("com.amazonaws.ebs#Ebs", "ebs"),

    CodegenTest("com.amazonaws.s3#AmazonS3", "s3")

)

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt

+814 −102

File changed.

Preview size limit exceeded, changes collapsed.

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/protocols/ServerHttpProtocolGenerator.kt

+1 −0
Original line number Diff line number Diff line
@@ -160,6 +160,7 @@ private class ServerHttpProtocolImplGenerator( 
        // Implement Axum `FromRequest` trait for input types.

        rustTemplate(

            """

            ##[derive(Debug)]

            pub struct $inputName(pub #{I});

            ##[#{AsyncTrait}::async_trait]

            impl<B> #{AxumCore}::extract::FromRequest<B> for $inputName