Unverified Commit e7cbcfff authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Prune extra xmlns from generated XML (#892) 

* Prune extra xmlns from generated XML

* Fix tests impacted by namespace serialization

* Update changelogs
parent 88fc7680

CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ vNext (Month Day, Year) 
=======================

**New this week**

- Fix typos in module documentation for generated crates (smithy-rs#920)

- Avoid serializing repetitive `xmlns` attributes in generated XML serializers. (aws-sdk-rust#301, smithy-rs#892)



**Breaking changes**
@@ -15,6 +16,7 @@ v0.31.0 (December 2nd, 2021) 
**New this week**

- Add docs.rs metadata section to all crates to document all features





v0.30.0-alpha (November 23rd, 2021)

===================================

aws/SDK_CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ vNext (Month Day, Year) 
=======================

**New this release**

- Fix typos in module documentation for generated crates (smithy-rs#920)

- Avoid serializing repetitive `xmlns` attributes in generated XML serializers. This reduces the length of serialized requests and should improve compatibility with localstack. (aws-sdk-rust#301, smithy-rs#892)





v0.2.0 (December 2nd, 2021)

===========================

aws/sdk/aws-models/s3-tests.smithy

+6 −6
Original line number Diff line number Diff line
@@ -111,17 +111,17 @@ apply PutBucketLifecycleConfiguration @httpRequestTests([ 
        headers: {

            // we can assert this, but when this test is promoted, it can't assert

            // on the exact contents

            "content-md5": "sUu+uAZPkTtAxJdaA+9uSg==",

            "content-md5": "JP8DTuCSH6yDC8wNGg4+mA==",

        },

        bodyMediaType: "application/xml",

        body: """

        <LifecycleConfiguration xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">

            <Rule xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">

                <Expiration xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">

                    <Days xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">1</Days>

            <Rule>

                <Expiration>

                    <Days>1</Days>

                </Expiration>

                <ID xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">Expire</ID>

                <Status xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">Enabled</Status>

                <ID>Expire</ID>

                <Status>Enabled</Status>

            </Rule>

        </LifecycleConfiguration>

        """,

aws/sdk/integration-tests/s3/Cargo.toml

+1 −0
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ aws-smithy-async = { path = "../../build/aws-sdk/sdk/aws-smithy-async" } 
aws-smithy-client = { path = "../../build/aws-sdk/sdk/aws-smithy-client", features = ["test-util"] }

aws-smithy-http = { path = "../../build/aws-sdk/sdk/aws-smithy-http" }

aws-smithy-types = { path = "../../build/aws-sdk/sdk/aws-smithy-types" }

aws-smithy-protocol-test = { path = "../../build/aws-sdk/sdk/aws-smithy-protocol-test" }

bytes = "1"

http = "0.2.3"

serde_json = "1"

aws/sdk/integration-tests/s3/tests/select-object-content.json

+19 −19
Original line number Diff line number Diff line
@@ -7,25 +7,25 @@ 
          "uri": "https://s3.us-east-2.amazonaws.com/aws-rust-sdk/sample_data.csv?select&select-type=2&x-id=SelectObjectContent",

          "headers": {

            "x-amz-date": [

              "20210831T010050Z"

              "20211126T205841Z"

            ],

            "x-amz-content-sha256": [

              "591d6c5a9bb1019b499d65fb01a6e473346ad65f2b513f03e17e388b3c788f53"

            ],

            "content-type": [

              "application/xml"

            ],

            "x-amz-content-sha256": [

              "3e2ed0bf97f28640f16193df06b497374232511cd2112b48985a306d40fb16d3"

            "user-agent": [

              "aws-sdk-rust/0.0.26-alpha os/macos lang/rust/1.53.0"

            ],

            "content-length": [

              "799"

            "x-amz-user-agent": [

              "aws-sdk-rust/0.0.26-alpha api/s3/0.0.26-alpha os/macos lang/rust/1.53.0"

            ],

            "authorization": [

              "AWS4-HMAC-SHA256 Credential=test/test/us-east-2/s3/aws4_request, SignedHeaders=content-length;content-type;host;x-amz-content-sha256;x-amz-date;x-amz-user-agent, Signature=test"

              "AWS4-HMAC-SHA256 Credential=test/20211126/us-east-2/s3/aws4_request, SignedHeaders=content-length;content-type;host;x-amz-content-sha256;x-amz-date;x-amz-user-agent, Signature=c7fd94cc4ec7b902c0d606919a350927c0cdcd625e7a0135c4bfa213dcedd4c1"

            ],

            "user-agent": [

              "aws-sdk-rust/0.1.0 os/linux lang/rust/1.52.1"

            ],

            "x-amz-user-agent": [

              "aws-sdk-rust/0.1.0 api/s3/0.0.16-alpha os/linux lang/rust/1.52.1"

            "content-length": [

              "415"

            ]

          },

          "method": "POST"
@@ -38,7 +38,7 @@ 
    "action": {

      "Data": {

        "data": {

          "Utf8": "<SelectObjectContentRequest xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><Expression xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">SELECT * FROM s3object s WHERE s.&quot;Name&quot; = &apos;Jane&apos;</Expression><ExpressionType xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">SQL</ExpressionType><InputSerialization xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><CSV xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><FileHeaderInfo xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">USE</FileHeaderInfo></CSV><CompressionType xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\">NONE</CompressionType></InputSerialization><OutputSerialization xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><CSV xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"></CSV></OutputSerialization></SelectObjectContentRequest>"

          "Utf8": "<SelectObjectContentRequest xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><Expression>SELECT * FROM s3object s WHERE s.&quot;Name&quot; = &apos;Jane&apos;</Expression><ExpressionType>SQL</ExpressionType><InputSerialization><CSV><FileHeaderInfo>USE</FileHeaderInfo></CSV><CompressionType>NONE</CompressionType></InputSerialization><OutputSerialization><CSV></CSV></OutputSerialization></SelectObjectContentRequest>"

        },

        "direction": "Request"

      }
@@ -62,20 +62,20 @@ 
            "status": 200,

            "version": "HTTP/1.1",

            "headers": {

              "x-amz-request-id": [

                "NVKMNP55BP15194G"

              "server": [

                "AmazonS3"

              ],

              "x-amz-id-2": [

                "geaWcKlzoJpu+EJLNG+t9uaD/9EOuQzGqcxL41SguR9xoDOVMFnjw7CFLm/yHQc3AVpHqHCo3a0="

              ],

              "date": [

                "Tue, 31 Aug 2021 01:00:52 GMT"

              ],

              "transfer-encoding": [

                "chunked"

              ],

              "server": [

                "AmazonS3"

              ],

              "date": [

                "Tue, 31 Aug 2021 01:00:52 GMT"

              "x-amz-request-id": [

                "NVKMNP55BP15194G"

              ]

            }

          }