Unverified Commit e3f0de42 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Move `Metadata` config bag type into a stable crate (#3325) 

This issue addresses a semver compatibility problem similar to the one
described in #3318, except for the
`aws_smithy_http::operation::Metadata` type.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 6ffd9900

CHANGELOG.next.toml

+7 −1
Original line number Diff line number Diff line
@@ -10,3 +10,9 @@ 
# references = ["smithy-rs#920"]

# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}

# author = "rcoh"



[[smithy-rs]]

message = "The `Metadata` storable was moved from aws_smithy_http into aws_smithy_runtime_api. A deprecated type alias was left in place with a note showing where the new location is."

references = ["smithy-rs#3325"]

meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client" }

author = "jdisanti"

codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/customizations/MetadataCustomization.kt

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ class MetadataCustomization( 
    private val runtimeConfig = codegenContext.runtimeConfig

    private val codegenScope by lazy {

        arrayOf(

            "Metadata" to RuntimeType.operationModule(runtimeConfig).resolve("Metadata"),

            "Metadata" to RuntimeType.smithyRuntimeApiClient(runtimeConfig).resolve("client::orchestrator::Metadata"),

        )

    }

codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/protocol/ProtocolParserGenerator.kt

+0 −1
Original line number Diff line number Diff line
@@ -56,7 +56,6 @@ class ProtocolParserGenerator( 
            "Headers" to RuntimeType.headers(codegenContext.runtimeConfig),

            "Response" to RuntimeType.smithyRuntimeApi(codegenContext.runtimeConfig).resolve("http::Response"),

            "http" to RuntimeType.Http,

            "operation" to RuntimeType.operationModule(codegenContext.runtimeConfig),

            "SdkBody" to RuntimeType.sdkBody(codegenContext.runtimeConfig),

        )

codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/protocol/RequestSerializerGenerator.kt

+0 −1
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ class RequestSerializerGenerator( 
            "HttpRequest" to runtimeApi.resolve("client::orchestrator::HttpRequest"),

            "HttpRequestBuilder" to RuntimeType.HttpRequestBuilder,

            "Input" to interceptorContext.resolve("Input"),

            "operation" to RuntimeType.operationModule(codegenContext.runtimeConfig),

            "SerializeRequest" to runtimeApi.resolve("client::ser_de::SerializeRequest"),

            "SdkBody" to RuntimeType.sdkBody(codegenContext.runtimeConfig),

            "HeaderSerializationSettings" to

codegen-client/src/test/kotlin/software/amazon/smithy/rust/codegen/client/smithy/customizations/MetadataCustomizationTest.kt

+1 −1
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@ class MetadataCustomizationTest { 
                    "BoxError" to RuntimeType.boxError(runtimeConfig),

                    "ConfigBag" to RuntimeType.configBag(runtimeConfig),

                    "Intercept" to RuntimeType.intercept(runtimeConfig),

                    "Metadata" to RuntimeType.operationModule(runtimeConfig).resolve("Metadata"),

                    "Metadata" to RuntimeType.smithyRuntimeApiClient(runtimeConfig).resolve("client::orchestrator::Metadata"),

                    "capture_request" to RuntimeType.captureRequest(runtimeConfig),

                    "RuntimeComponents" to

                        RuntimeType.smithyRuntimeApiClient(runtimeConfig)